Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAIHarvest: harvesting "from beginning" fix #2793

Closed

Conversation

jalavik
Copy link
Contributor

@jalavik jalavik commented Feb 17, 2015

  • Fixes an exception that would happen upon the initial harvest
    of a new OAI harvest source marked to be harvested "from beginning".

Reported-by: Jean-Yves Le Meur [email protected]
Signed-off-by: Jan Aage Lavik [email protected]

@jalavik
Copy link
Contributor Author

jalavik commented Feb 17, 2015

@tiborsimko OAI harvesting "from beginning" has been broken for a while and this is the fix - dunno if it will make for the next release, so I put it in 1.3 for now..

@kaplun kaplun modified the milestones: v1.2.x, v1.3 Mar 4, 2015
@kaplun
Copy link
Member

kaplun commented Mar 4, 2015

The code looks good!

* SECURITY Adds back the `HttpOnly` cookie attribute in order to better
  protect against potential XSS vulnerabilities.  (closes inveniosoftware#3064)

Signed-off-by: Tibor Simko <[email protected]>
Reviewed-by: Samuele Kaplun <[email protected]>
* maint-1.0:
  WebStyle: HttpOnly cookie attribute

Conflicts:
	modules/websession/lib/session.py
	modules/webstyle/lib/webinterface_handler_wsgi_utils.py

Signed-off-by: Tibor Simko <[email protected]>
* maint-1.1:
  WebStyle: HttpOnly cookie attribute

Conflicts:
	modules/websession/lib/session.py
	modules/webstyle/lib/webinterface_handler_wsgi_utils.py

Signed-off-by: Tibor Simko <[email protected]>
* Adds HttpOnly attribute to stub cookies as well.  (addresses inveniosoftware#3064)

Signed-off-by: Tibor Simko <[email protected]>
Reviewed-by: Lars Holm Nielsen <[email protected]>
* maint-1.1:
  WebSession: HttpOnly attribute in stub cookies

Signed-off-by: Tibor Simko <[email protected]>
* SECURITY Improves URL redirecting by properly quoting all URL parts,
  in order to better protect against possible XSS attacks.

Signed-off-by: Tibor Simko <[email protected]>
Reviewed-by: Samuele Kaplun <[email protected]>
@tiborsimko
Copy link
Member

  • Please update the commit log message to put the FIX label in front, so that this will be well reported in the automatically generated release notes.
  • Please add Reviewed-by: Samuele Kaplun <[email protected]>

* FIX Fixes an exception that would happen upon the initial harvest
  of a new OAI harvest source marked to be harvested "from beginning".

Reported-by: Jean-Yves Le Meur <[email protected]>
Reviewed-by: Samuele Kaplun <[email protected]>
Signed-off-by: Jan Aage Lavik <[email protected]>
@jalavik
Copy link
Contributor Author

jalavik commented May 20, 2015

@tiborsimko Done!

@jalavik jalavik assigned tiborsimko and unassigned jalavik May 20, 2015
tiborsimko pushed a commit that referenced this pull request Mar 24, 2016
* FIX Fixes an exception that would happen upon the initial harvest
  of a new OAI harvest source marked to be harvested "from beginning".
  (closes #2793)

Reported-by: Jean-Yves Le Meur <[email protected]>
Reviewed-by: Samuele Kaplun <[email protected]>
Signed-off-by: Jan Aage Lavik <[email protected]>
@tiborsimko
Copy link
Member

Thanks, merged as 3909c53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants