Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inveniogc: missing recurse parameter for dir deletions #3556

Closed
aw-bib opened this issue Nov 5, 2015 · 1 comment
Closed

inveniogc: missing recurse parameter for dir deletions #3556

aw-bib opened this issue Nov 5, 2015 · 1 comment
Assignees
@tiborsimko
Labels
Component: WebSession
Milestone
v1.1.7

Comments

@aw-bib
Copy link
Contributor

aw-bib commented Nov 5, 2015

The following rules in inveniogc.py miss out the fact that they actually find a directory and not a file. Thus they have to use -rf for deletion and not only -f:

  • websubmit_icon_creator_*
  • websubmit_file_stamper_*

This should affect maint-1.1 and maint-1.2 and can amount to quite some space used depending on the input files.
aw-bib added a commit to aw-bib/invenio that referenced this issue Nov 5, 2015
@aw-bib
inveniogc: tempdir deletion
c8d638c 
FIX websubmit_icon_creator and  websubmit_file_stamper create tempdirs
instead of files thus deletion has to be recursive.

Addresses inveniosoftware#3556

Signed-off-by: Alexander Wagner <[email protected]>
@aw-bib aw-bib mentioned this issue Nov 5, 2015
Closed
@tiborsimko tiborsimko added this to the v1.1.7 milestone Nov 12, 2016
@tiborsimko tiborsimko self-assigned this Nov 12, 2016
tiborsimko pushed a commit to tiborsimko/invenio that referenced this issue Nov 12, 2016
@aw-bib @tiborsimko
inveniogc: better tempdir deletion
b455b95 
* FIX Fixes garbage collection of temporary directories created by
  websubmit_icon_creator and websubmit_file_stamper.
  (closes inveniosoftware#3556) (PR inveniosoftware#3558)

Signed-off-by: Alexander Wagner <[email protected]>
@tiborsimko tiborsimko mentioned this issue Nov 12, 2016
Merged
@tiborsimko
Copy link
Member

Closed by #3716.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiborsimko tiborsimko

Labels
Component: WebSession
Projects
None yet
Milestone
v1.1.7
Development

No branches or pull requests
2 participants
@tiborsimko @aw-bib