Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAccess: minor ommission in a doc example (regarding groups and fireroles) may produce an exception #3107

Closed
sbujam opened this issue May 7, 2015 · 1 comment

Comments

@sbujam
Copy link
Contributor

sbujam commented May 7, 2015

It seems that if one follows the example in the WebAccess docs, and tries to enter:
deny group badguys
in a firerole, an exception is thrown.

By reading the code, I found out that the solution is VERY simple: I just have to put single or double quotes in the groupname to make it work! So,
deny group 'badguys'

is OK and produces no exceptions.

The requirement to have expressions included in quotes is very reasonable, so my proposal is to simply change the example(s) in the docs, according to this requirement.

@jirikuncar jirikuncar changed the title Minor ommission in a WebAccess doc example (regarding groups and fireroles) may produce an exception WebAccess: minor ommission in a doc example (regarding groups and fireroles) may produce an exception May 7, 2015
@tiborsimko tiborsimko modified the milestones: v1.2.1, v1.2.2 May 15, 2015
@kaplun kaplun modified the milestones: v1.0.10, v1.2.2 Jun 4, 2015
kaplun added a commit to kaplun/invenio that referenced this issue Jun 4, 2015
* FIX Improves the WebAccess FireRole documentation by providing
  corrected example on how to use groups in FireRole definitions.
  (closes inveniosoftware#3107)

Signed-off-by: Samuele Kaplun <[email protected]>
Reported-by: Theodoros Theodoropoulos <[email protected]>
tiborsimko pushed a commit that referenced this issue Mar 24, 2016
* FIX Improves the WebAccess FireRole documentation by providing
  corrected example on how to use groups in FireRole definitions.
  (closes #3107) (closes #3225)

Signed-off-by: Samuele Kaplun <[email protected]>
Reported-by: Theodoros Theodoropoulos <[email protected]>
@tiborsimko
Copy link
Member

Thanks, merged as e7ba096.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants