Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSearch: detailed record page tabs miss language parameter in CFG_SITE_LANG #308

Closed
jeromecaffaro opened this issue Apr 30, 2014 · 5 comments
Closed

WebSearch: detailed record page tabs miss language parameter in CFG_SITE_LANG #308

jeromecaffaro opened this issue Apr 30, 2014 · 5 comments
Assignees
@drjova
Labels
Component: WebSearch Service: CDS Size: easy Type: enhancement
Milestone
v1.2.2

Comments

@jeromecaffaro
Copy link
Member

Originally on 2010-10-11

Tabs ("References", "Discussion", etc.) on detailed record pages miss on purpose the 'ln=XX' parameter when the page is viewed in language 'CFG_SITE_LANG' (for eg: http://invenio-demo.cern.ch/record/96?ln=en): the consequence is that the browser preferred language is used when clicking on these tabs even if the user has specifically chosen to view the detailed page in language 'CFG_SITE_LANG'.

'ln=XX' should now be added whatever the value of 'CFG_SITE_LANG' is (in search_engine.py).
@jirikuncar jirikuncar added this to the v1.2.x milestone Mar 23, 2015
@jirikuncar
Copy link
Member

@egabancho @switowski is it still relevant to CDS?

@switowski
Copy link
Member

@jirikuncar the problem still exists on CDS

@switowski
Copy link
Member

I have create a Jira ticket for this issue: https://its.cern.ch/jira/browse/CDS-672

@tiborsimko
Copy link
Member

the problem still exists on CDS

... and on Invenio demo site v1.2.0 as well. The language had been well added to most links, but it seems the tabs were missed.

@tiborsimko tiborsimko modified the milestones: v1.2.1, v1.2.2 May 20, 2015
@drjova drjova mentioned this issue Jun 23, 2015
Closed
@egabancho egabancho assigned drjova and unassigned switowski Jun 29, 2015
drjova added a commit to CERNDocumentServer/invenio that referenced this issue Jul 24, 2015
@drjova @egabancho
WebSearch: tabs miss language parameter
beb944a 
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred. (closes
  inveniosoftware#308)

Signed-off-by: Harris Tzovanakis <[email protected]>
@drjova drjova mentioned this issue Jul 27, 2015
Closed
drjova added a commit to CERNDocumentServer/invenio that referenced this issue Sep 1, 2015
@drjova @switowski
WebSearch: tabs miss language parameter
3f0b6e6 
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred. (closes
  inveniosoftware#308)

Signed-off-by: Harris Tzovanakis <[email protected]>
egabancho pushed a commit to CERNDocumentServer/invenio that referenced this issue Mar 10, 2016
@drjova
WebSearch: tabs miss language parameter
1ab4d24 
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred. (closes
  inveniosoftware#308)

Signed-off-by: Harris Tzovanakis <[email protected]>
egabancho pushed a commit to CERNDocumentServer/invenio that referenced this issue Mar 10, 2016
@drjova @egabancho
WebSearch: tabs miss language parameter
60bacdd 
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred. (closes
  inveniosoftware#308)

Signed-off-by: Harris Tzovanakis <[email protected]>
egabancho pushed a commit to CERNDocumentServer/invenio that referenced this issue May 9, 2016
@drjova
WebSearch: tabs miss language parameter
e1eaf53 
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred. (closes
  inveniosoftware#308)

Signed-off-by: Harris Tzovanakis <[email protected]>
tiborsimko pushed a commit to tiborsimko/invenio that referenced this issue Nov 24, 2016
@drjova @tiborsimko
WebSearch: tabs miss language parameter
e8bc2c8 
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred.
  (closes inveniosoftware#308) (PR inveniosoftware#3395)

Signed-off-by: Harris Tzovanakis <[email protected]>
tiborsimko pushed a commit to tiborsimko/invenio that referenced this issue Nov 24, 2016
@drjova @tiborsimko
WebSearch: tabs miss language parameter
7d5fd3f 
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred.
  (closes inveniosoftware#308) (PR inveniosoftware#3395)

Signed-off-by: Harris Tzovanakis <[email protected]>
@tiborsimko
Copy link
Member

Closed by #3729.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drjova drjova

Labels
Component: WebSearch Service: CDS Size: easy Type: enhancement
Projects
None yet
Milestone
v1.2.2
Development

No branches or pull requests
5 participants
@jirikuncar @tiborsimko @jeromecaffaro @drjova @switowski