New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlalchemy: PostgreSQL - type Text and Integer compatibility #3037

Closed

hachreak opened this issue Apr 20, 2015 · 1 comment · Fixed by #3045

Assignees

Labels

Milestone

Member

hachreak commented Apr 20, 2015

PostgreSQL Text type doesn't accept length parameter: http://www.postgresql.org/docs/9.1/static/datatype-character.html

ProgrammingError: (psycopg2.ProgrammingError) type modifier is not allowed for type "text"
LINE 5:  value TEXT(35) NOT NULL,
                ^
[SQL: "\nCREATE TABLE bib00x (\n\tid SERIAL NOT NULL, \n\ttag VARCHAR(6) DEFAULT '' NOT NULL, \n\tvalue TEXT(35) NOT NULL, \n\tPRIMARY KEY (id)\n)\n\n"]

I tried to ask to zzzeek if exists a easy solution to this problem: https://bitbucket.org/zzzeek/sqlalchemy/issue/3370/text-and-length

In alternative, with @jirikuncar, we agree to resolve in the same way as for Integer

jirikuncar added this to the v2.1 milestone

jirikuncar assigned hachreak

jirikuncar added the Type: bug label

jirikuncar changed the title ~~PostgreSQL - type Text compatibility~~ sqlalchemy: PostgreSQL - type Text compatibility

Member Author

hachreak commented Apr 21, 2015

I found that also Integer give us problems if we use latest version of SQLAlchemy 1.0.0.
zzzeek told me about a solution (maybe applicable also to solve integer problem).

So, summarizing all problems:

Integer problem: Integer takes no parameters
Text don't take length (see for the solution)

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

546199e

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (addresses inveniosoftware#3037)

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

15deb1f

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (addresses inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

a5762d1

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (addresses inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          sqlalchemy: text type default constructor fix

24780e9

* Addresses issue with default constructor on types that do not
  accept arguments in SQLAlchemy>=1.0.0. (closes inveniosoftware#3037)

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

67cf626

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (addresses inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: Integer type compatibility fix

8e2a6f2

* Changes Integer in models because from SQLAlchemy>=1.0 it's arised a
  exceptions on use LegacyInteger. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: Integer type compatibility fix

* Changes Integer in models because from SQLAlchemy>=1.0 it's arised a
  exceptions on use LegacyInteger. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak changed the title ~~sqlalchemy: PostgreSQL - type Text compatibility~~ sqlalchemy: PostgreSQL - type Text and Integer compatibility

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

2622a7a

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (addresses inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: Integer type compatibility fix

39002fe

* Changes Integer in models because from SQLAlchemy>=1.0 it's arised a
  exceptions on use LegacyInteger. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

e20c91c

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (addresses inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: Integer type compatibility fix

32a1ff2

* Changes Integer in models because from SQLAlchemy>=1.0 it's arised a
  exceptions on use LegacyInteger. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

Conflicts:
	invenio/modules/tags/models.py

hachreak mentioned this issue

global: PostgreSQL Text type compatibility fix #3045

Merged

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

283c407

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (addresses inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

b680058

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

1abcd37

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

d6a8635

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

c52d6c5

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

581fcc0

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

3dd7144

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

54bfdaf

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* Refactores SbmFORMATEXTENSION and sbmGFILERESULT.

* Removes Invenio hacks on MySQL Index and Primary Key creation.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

cbb7787

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* Adds id column in SbmFORMATEXTENSION and sbmGFILERESULT.

* Removes Invenio hacks on MySQL Index and Primary Key creation.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak mentioned this issue

global: fully functional PostgreSQL DB backend #3079

Closed

20 tasks

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

e8be0a1

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* Adds id column in SbmFORMATEXTENSION and sbmGFILERESULT.

* Removes Invenio hacks on MySQL Index and Primary Key creation.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

b1275f3

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* Adds id column in SbmFORMATEXTENSION and sbmGFILERESULT.

* Removes Invenio hacks on MySQL Index and Primary Key creation.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

892d571

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* Adds id column in SbmFORMATEXTENSION and sbmGFILERESULT.

* Removes Invenio hacks on MySQL Index and Primary Key creation.

* Updates minimum Flask-Admin version to 1.1.0.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

dada7de

* Changes Text in models because from SQLAlchemy>=1.0 it's arised a
  exception if the length is specified. (closes inveniosoftware#3037)

* Adds id column in SbmFORMATEXTENSION and sbmGFILERESULT.

* Removes Invenio hacks on MySQL Index and Primary Key creation.

* Updates minimum Flask-Admin version to 1.1.0.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

31948c3

* BETTER Improves compatibility of Text fields  in PostrgeSQL by
  changing Text in models and removes Invenio hacks on MySQL Index and
  Primary Key creation because starting from SQLAlchemy>=1.0 it arises
  an exception if the length is specified. (addresses inveniosoftware#3037)

* Updates minimum Flask-Admin version to 1.1.0.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          submit: PostgreSQL Text type compatibility fix

40a3694

* Changes Text in models and removes Invenio hacks on MySQL
  Index and Primary Key creation because starting from SQLAlchemy>=1.0
  it arises an exception if the length is specified. (closes inveniosoftware#3037)

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          submit: PostgreSQL Text type compatibility fix

7d2c709

* Changes Text in models because starting from SQLAlchemy>=1.0
  it arises an exception if the length is specified. (closes inveniosoftware#3037)

* Removes a text composed primary keys because SQLAlchemy seems to have
  a issue on this kind of definition. Uses a id as primary key and a
  recipe to upgrade the database to compensate.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          submit: PostgreSQL Text type compatibility fix

96a2127

* Changes Text in models because starting from SQLAlchemy>=1.0
  it arises an exception if the length is specified. (closes inveniosoftware#3037)

* Adds new column 'id’ with a primary key and implements upgrade recipe
  to modify the tables sbmFORMATEXTENSION and sbmGFILERESULT.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

4a207c3

* BETTER Improves compatibility of Text fields  in PostrgeSQL by
  changing Text in models and removes Invenio hacks on MySQL Index and
  Primary Key creation because starting from SQLAlchemy>=1.0 it arises
  an exception if the length is specified. (addresses inveniosoftware#3037)

* Updates minimum Flask-Admin version to 1.1.0.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          submit: PostgreSQL Text type compatibility fix

8582eef

* Changes Text in models because starting from SQLAlchemy>=1.0
  it arises an exception if the length is specified. (closes inveniosoftware#3037)

* Adds new column 'id’ with a primary key and implements upgrade recipe
  to modify the tables sbmFORMATEXTENSION and sbmGFILERESULT.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          submit: PostgreSQL Text type compatibility fix

ec82926

* Changes Text in models because starting from SQLAlchemy>=1.0
  it arises an exception if the length is specified. (closes inveniosoftware#3037)

* Adds new column 'id' with a primary key and implements upgrade recipe
  to modify the tables sbmFORMATEXTENSION and sbmGFILERESULT.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

47e2031

* BETTER Improves compatibility of Text fields in PostrgeSQL by
  changing Text in models and removes Invenio hacks on MySQL Index and
  Primary Key creation because starting from SQLAlchemy>=1.0 it arises
  an exception if the length is specified. (addresses inveniosoftware#3037)

* Updates minimum Flask-Admin version to 1.1.0.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

hachreak pushed a commit to hachreak/invenio that referenced this issue


          submit: PostgreSQL Text type compatibility fix

e77da44

* Changes Text in models because starting from SQLAlchemy>=1.0
  it arises an exception if the length is specified. (closes inveniosoftware#3037)

* Adds new column 'id' with a primary key and implements upgrade recipe
  to modify the tables sbmFORMATEXTENSION and sbmGFILERESULT.

Signed-off-by: Leonardo Rossi <[email protected]>

jirikuncar closed this as completed in #3045

jmartinm pushed a commit to jmartinm/invenio that referenced this issue


          global: PostgreSQL Text type compatibility fix

7c77fc9

* BETTER Improves compatibility of Text fields in PostrgeSQL by
  changing Text in models and removes Invenio hacks on MySQL Index and
  Primary Key creation because starting from SQLAlchemy>=1.0 it arises
  an exception if the length is specified. (addresses inveniosoftware#3037)

* Updates minimum Flask-Admin version to 1.1.0.

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment