Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation: database password escaping #2844

Closed
eamonnmag opened this issue Mar 4, 2015 · 0 comments
Closed

installation: database password escaping #2844

eamonnmag opened this issue Mar 4, 2015 · 0 comments
Labels
Branch: master Component: installation Type: bug
Milestone
v2.1.0

Comments

@eamonnmag
Copy link
Contributor

I've been following the INSTALL.rst instructions for installation of the pu branch.

When setting the database password (CFG_DATABASE_PASS) in the configuration, either through inveniomanage or via manual editing of the cfg file, there is an inconsistency.

If the password is set as password with no quotes, this command fails:
inveniomanage database init --user=root --password=$MYSQL_ROOT --yes-i-know
Since the resulting SQL is invalid without the password wrapped in quotes.

When the password is wrapped in quotes, this command will work.
However, now the below command will fail to work
inveniomanage database create

So to get this working, you have to edit the config file again and remove the quotes, leaving u'password' in place.
eamonnmag added a commit to eamonnmag/invenio that referenced this issue Mar 4, 2015
@eamonnmag
Updated database.py to wrap password for init script in quotes
3fcf5df 
Fixes inveniosoftware#2844
This was referenced Mar 4, 2015
Merged
Closed
@jirikuncar jirikuncar added this to the v2.0.0 milestone Mar 4, 2015
@jirikuncar jirikuncar modified the milestones: v2.0.x, v2.0.0 Mar 4, 2015
@jirikuncar jirikuncar changed the title Database password configuration issue for installation installation: database password escaping Mar 4, 2015
@jirikuncar jirikuncar modified the milestones: v2.0.1, 2.0.x, v2.1, 2.0.2 Mar 20, 2015
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 20, 2015
script: better database initialization
7f223af 
* BETTER Uses SQLAlchemy to init the database instead of execute mysql
  in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 20, 2015
script: better database initialization
2674834 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of execute mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 20, 2015
script: better database initialization
0ff21f6 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of execute mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 27, 2015
script: better database initialization
ea0b600 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of execute mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 30, 2015
script: better database initialization
35e5eea 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of execute mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
script: better database initialization
a9d954f 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of execute mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 2, 2015
script: better database initialization
fd34277 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of executing mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 2, 2015
script: better database initialization
7595016 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of executing mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 2, 2015
script: better database initialization
17004e1 
* BETTER Uses SQLAlchemy and SQLAlchemy-Utils to init the database
  instead of executing mysql in a python subshell.
  (closes inveniosoftware#2846) (closes inveniosoftware#2844)

* NEW Adds support for PostgreSQL database initialization.

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Branch: master Component: installation Type: bug
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
2 participants
@jirikuncar @eamonnmag