Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: set proper Cache and TTL information in HTTP headers #2302

Closed
tiborsimko opened this issue Sep 19, 2014 · 2 comments · Fixed by #3103
Closed

search: set proper Cache and TTL information in HTTP headers #2302

tiborsimko opened this issue Sep 19, 2014 · 2 comments · Fixed by #3103
Assignees
@jirikuncar
Labels
Branch: master Component: WebSearch Type: enhancement
Milestone
v2.1.0

Comments

@tiborsimko
Copy link
Member

The /search pages use Redis as a backend to store user-selected facets. The Redis cache for these facets expires after N minutes. The search results pages should therefore emit proper Cache and TTL information in its HTTP headers, so that any eventual external cachers (such as varnish) could act accordingly to invalidate their caches automatically, without any configuration.
@tiborsimko tiborsimko added this to the v2.0.x milestone Sep 19, 2014
@tiborsimko
Copy link
Member Author

(BTW see also #2291)

@jirikuncar jirikuncar modified the milestones: v2.1, v2.0.x Mar 13, 2015
@jirikuncar
Copy link
Member

Facets should reuse all query arguments intead of qid so that the redis cache can be rebuild when needed in search engine.

related #2987

jirikuncar added a commit to jirikuncar/invenio that referenced this issue May 6, 2015
@jirikuncar
search: proper Cache and TTL info in HTTP headers
266e213 
* BETTER The search results pages emits proper Cache and TTL
  information in its HTTP headers, so that any eventual external
  cachers (such as varnish) could act accordingly to invalidate their
  caches automatically, without any configuration.  (closes inveniosoftware#2302)

Reviewed-by: Tibor Simko <[email protected]>
Signed-off-by: Jiri Kuncar <[email protected]>
@jirikuncar jirikuncar mentioned this issue May 6, 2015
Merged
jirikuncar added a commit to jirikuncar/invenio that referenced this issue May 6, 2015
@jirikuncar
search: proper Cache and TTL info in HTTP headers
12661e1 
* BETTER The search results pages emits proper Cache and TTL
  information in its HTTP headers, so that any eventual external
  cachers (such as varnish) could act accordingly to invalidate their
  caches automatically, without any configuration.  (closes inveniosoftware#2302)

Reviewed-by: Tibor Simko <[email protected]>
Signed-off-by: Jiri Kuncar <[email protected]>
jirikuncar added a commit to jirikuncar/invenio that referenced this issue May 7, 2015
@jirikuncar
search: proper Cache and TTL info in HTTP headers
42918d2 
* BETTER The search results pages emits proper Cache and TTL
  information in its HTTP headers, so that any eventual external
  cachers (such as varnish) could act accordingly to invalidate their
  caches automatically, without any configuration.  (closes inveniosoftware#2302)

Reviewed-by: Tibor Simko <[email protected]>
Signed-off-by: Jiri Kuncar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jirikuncar jirikuncar

Labels
Branch: master Component: WebSearch Type: enhancement
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

search: proper Cache and TTL info in HTTP headers jirikuncar/invenio
2 participants
@jirikuncar @tiborsimko