Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response is not correct for no records #186

Closed
rerowep opened this issue Jun 3, 2020 · 3 comments
Closed

response is not correct for no records #186

rerowep opened this issue Jun 3, 2020 · 3 comments

Comments

@rerowep
Copy link
Contributor

rerowep commented Jun 3, 2020

If we have no records the <ListRecords> opening tag is missing.

<?xml version=\'1.0\' encoding=\'UTF-8\'?>
<?xml-stylesheet type="text/xsl" href="/static/xsl/oai.xsl"?>
<OAI-PMH xmlns="http://www.openarchives.org/OAI/2.0/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd">
  <responseDate>2020-06-02T23:00:28Z</responseDate>
  <request until="2020-06-02T23:00:28+00:00Z" from_="2020-06-02T06:00:00+00:00Z" metadataPrefix="marc21" verb="ListRecords">
    https://localhost:5000/oai2d
  </request>
  
  <ListRecords/>
</OAI-PMH>
@wgresshoff
Copy link

wgresshoff commented Jun 3, 2020

<ListRecords/> is an opening and closing tag at the same time. But in my opinion, if the response of ListRecords is empty, the should be no <ListRecords> tag at all but
<error code="noRecordsMatch"/> instead. But this is surely open for discussion, the spec is not so clear about it.

rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jun 8, 2020
* Updates invenio version to 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jun 8, 2020
* Updates invenio version to 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jun 8, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep closed this as completed Jun 8, 2020
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jun 15, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
@pronguen
Copy link

pronguen commented Jun 18, 2020

If there are no records to be returned, the OAI provider should not send ListRecords response with empty contents, but noRecordsMatch error message.
Please see "Error and Exception Conditions" section in: http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions

We are using Ex-libris Primo, a java client very common and often used in libraries, and it does not understand an empty ListRecords tag. Python clients seem therefore to understand such a response.

@pronguen pronguen reopened this Jun 18, 2020
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jun 22, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jul 13, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jul 20, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Jul 20, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Sep 6, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Sep 6, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Sep 6, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Oct 2, 2020
* Upgrades invenio to version 3.3.0

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Oct 7, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Oct 7, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Oct 7, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Oct 7, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Oct 7, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Oct 22, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 1, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 5, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 6, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 8, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 17, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 26, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Nov 26, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Dec 14, 2020
* Upgrades invenio to version 3.3.0.
* Uses Github action for tests.

Invenio-oaiserver is not functional in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ebooks that referenced this issue Dec 17, 2020
* Uses Github action for tests.

Invenio-oaiserver is not functional with marshmallow 2 in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rero/rero-ebooks that referenced this issue Dec 17, 2020
* Uses Github action for tests.

Invenio-oaiserver is not functional with marshmallow 2 in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rero/rero-ebooks that referenced this issue Dec 17, 2020
* Uses Github action for tests.

Invenio-oaiserver is not functional with marshmallow 2 in this version:
- inveniosoftware/invenio-oaiserver#178
- inveniosoftware/invenio-oaiserver#185
- inveniosoftware/invenio-oaiserver#186

Co-Authored-by: Peter Weber <[email protected]>
@jesusbagpuss
Copy link

This issue has just been reported on the OAI-PMH Google group.

A zenodo repository was failing it's validation, as the set chosen to validate against (in their case, the openaire set) didn't contain any records, but output an empty <ListIdentifiers/> element rather than the expected <error code="noRecordsMatch"/>.

Currently they are unable to register their OAI-PMH endpoint.

@rekt-hard rekt-hard mentioned this issue Jan 24, 2022
@rerowep rerowep closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants