Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix default queue; don't error on empty args #43

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

yashlamba
Copy link
Member

@yashlamba yashlamba commented Jul 19, 2024

  • The queue selected by default when doing a manual run should be the default queue for that job.
  • Running with empty args used to create a run with default args and also raise a validation error. Now the error is not shown the case of empty args.

Comment on lines +76 to +78
config={config}
onError={this.onError}
queue={queue}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config={config}
onError={this.onError}
queue={queue}
args={args}
queue={queue}
onError={this.onError}
  1. nit: order of parameters :)
  2. nit/other: not sure why it's config and not args so that it matches what is expected in the REST API payload

@slint slint merged commit 30c2b3d into inveniosoftware:master Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants