Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communities-ui: verified icon display logic change and deterministic sorting #2885

Conversation

ptamarit
Copy link
Member

@ptamarit ptamarit commented Oct 18, 2024

❤️ Thank you for your contribution!

Partially fixes inveniosoftware/invenio-communities#1234
Second iteration on changes in #2883

Description

  • Not relying on the verified field which is not serialized for non admins
  • Showing an icon next to parent communities too
  • Deterministic sorting of communities

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@ptamarit ptamarit requested a review from slint October 18, 2024 13:21
@ptamarit ptamarit force-pushed the communities-ui-verified-display-logic-change-sorting branch 3 times, most recently from 748dc26 to 2f35639 Compare October 18, 2024 15:10
@ptamarit ptamarit force-pushed the communities-ui-verified-display-logic-change-sorting branch from 2f35639 to 1f1d7ba Compare October 18, 2024 15:23
@ptamarit ptamarit merged commit 98e0479 into inveniosoftware:master Oct 18, 2024
4 checks passed
@ptamarit ptamarit deleted the communities-ui-verified-display-logic-change-sorting branch October 18, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Add verified check for communities + parent community info
2 participants