Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js/remove warnings #2877

Merged
merged 3 commits into from
Oct 23, 2024
Merged

js/remove warnings #2877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5eb338
fix: react warning
utnapischtim Oct 1, 2024
dd756fd
fix: propsTypes warning
utnapischtim Oct 1, 2024
6f22448
fix: Warning '_truncate' is defined but never used
utnapischtim Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ..._app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/components/RecordsResultsListItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import { i18next } from "@translations/invenio_app_rdm/i18next";
import _get from "lodash/get";
import _truncate from "lodash/truncate";
import React, { Component } from "react";
import Overridable from "react-overridable";
import { SearchItemCreators } from "../utils";
Expand Down
2 changes: 1 addition & 1 deletion invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ export class RDMDepositForm extends Component {
RDMDepositForm.propTypes = {
groupsEnabled: PropTypes.bool.isRequired,
config: PropTypes.object.isRequired,
recordRestrictionGracePeriod: PropTypes.object.isRequired,
recordRestrictionGracePeriod: PropTypes.number.isRequired,
allowRecordRestriction: PropTypes.bool.isRequired,
record: PropTypes.object.isRequired,
preselectedCommunity: PropTypes.object,
Expand Down
1 change: 0 additions & 1 deletion .../semantic-ui/js/invenio_app_rdm/user_dashboard/uploads_items/ComputerTabletUploadsItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import { i18next } from "@translations/invenio_app_rdm/i18next";
import React from "react";
import PropTypes from "prop-types";
import _truncate from "lodash/truncate";
import _get from "lodash/get";
import { Button, Icon, Item, Label } from "semantic-ui-react";
import { SearchItemCreators } from "../../utils";
Expand Down
5 changes: 2 additions & 3 deletions ...e/assets/semantic-ui/js/invenio_app_rdm/user_dashboard/uploads_items/MobileUploadsItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import { i18next } from "@translations/invenio_app_rdm/i18next";
import React from "react";
import PropTypes from "prop-types";
import _truncate from "lodash/truncate";
import _get from "lodash/get";
import { Dropdown, Icon, Item, Label } from "semantic-ui-react";
import { SearchItemCreators } from "../../utils";
Expand Down Expand Up @@ -125,14 +124,14 @@ export const MobileUploadsItem = ({
<Dropdown.Menu>
<Dropdown.Item
onClick={() => editRecord()}
labelPosition="left"
labelposition="left"
icon="edit"
content={i18next.t("Edit")}
/>

{isPublished && (
<Dropdown.Item
labelPosition="left"
labelposition="left"
href={viewLink}
icon="eye"
content={i18next.t("View")}
Expand Down