Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace view_func with default_view_func to make APP_RDM_USER_DASHBOARD_ROUTES overwriteable #2831

Conversation

karkraeg
Copy link
Member

@karkraeg karkraeg commented Sep 5, 2024

❤️ Thank you for your contribution!

Description

This change makes APP_RDM_USER_DASHBOARD_ROUTES configurable by using an approach like this in invenio.cfg:

from invenio_app_rdm.config import APP_RDM_ROUTES
from invenio_app_rdm.config import APP_RDM_USER_DASHBOARD_ROUTES
from mysite.views import custom_render
APP_RDM_ROUTES["index"] = ("/", custom_render)
APP_RDM_USER_DASHBOARD_ROUTES["uploads"] = ("/me/uploads", custom_render)

@karkraeg
Copy link
Member Author

Hi @alejandromumo do you think that's a good solution, or do you see anything speaking against it from your perspective?

@karkraeg karkraeg changed the title replace view_func with default_view_func to make them overwriteable replace view_func with default_view_func to make APP_RDM_USER_DASHBOARD_ROUTES overwriteable Oct 15, 2024
@karkraeg
Copy link
Member Author

I'll close this in favor of https://github.com/inveniosoftware/invenio-app-rdm/pull/2831 b because there is no need for now to change this. It's better to fix the actual bug in the JS Code than to change how this configuration variable behaves.

@karkraeg karkraeg closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APP_RDM_USER_DASHBOARD_ROUTES can't be reconfigured with tuples
1 participant