Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Update from FDM.jl to FiniteDifferences.jl #181

Closed
wants to merge 2 commits into from
Closed

Update from FDM.jl to FiniteDifferences.jl #181

wants to merge 2 commits into from

Conversation

nickrobinson251
Copy link
Contributor

@nickrobinson251
Copy link
Contributor Author

nickrobinson251 commented Oct 14, 2019 •
edited
Loading

same unrelated failure as #180 (comment)

see #182

willtebbutt
willtebbutt approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for sorting this out.

@willtebbutt
Copy link
Member

willtebbutt commented Oct 14, 2019 •
edited
Loading

(The loggamma stuff causing CI failures is orthogonal to this PR and therefore shouldn't block this PR)

@oxinabox
Copy link
Member

We should just sort that out before we merge this,
as that way we can know fore sure that this doesn't also have issues.
And this is not a high priority PR we need to get in ASAP so I think we can just wait til we fix that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

@eperim eperim Awaiting requested review from eperim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickrobinson251 @willtebbutt @oxinabox