Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alternative theme usage syntax #53

Merged
merged 2 commits into from
Apr 18, 2021
Merged

add alternative theme usage syntax #53

merged 2 commits into from
Apr 18, 2021

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Apr 18, 2021

What Changed

Add new theme("VARIABLE_NAME") syntax.

Why

It is easier to read.

Todo:

  • Add tests
  • Add docs

Published PR with canary version: 2.7.0-canary.53.684

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Apr 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@322893c). Click here to learn what that means.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage          ?   88.11%           
=========================================
  Files             ?        5           
  Lines             ?      345           
  Branches          ?       89           
=========================================
  Hits              ?      304           
  Misses            ?       25           
  Partials          ?       16           
Impacted Files Coverage Δ
src/index.ts 83.78% <50.00%> (ø)
src/common/index.ts 79.77% <70.00%> (ø)
src/legacy/index.ts 96.38% <88.23%> (ø)
src/modern/index.ts 89.39% <92.68%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322893c...89af81c. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 7d189d6 into master Apr 18, 2021
@hipstersmoothie hipstersmoothie deleted the new-syntax branch April 18, 2021 19:31
@hipstersmoothie
Copy link
Contributor Author

🚀 PR was released in v2.7.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants