Add condition checks in build_bundle.sh #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feuerste
reviewed
Nov 25, 2025
feuerste
reviewed
Nov 26, 2025
feuerste
approved these changes
Nov 28, 2025
Contributor
|
@mjcarroll Can you please also have a quick look? |
mjcarroll
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
scripts/build_bundle.shscript to make the bundling process more robust by conditionally including files based on their existence in the container. The main improvement is that the bundle now only contains files that are actually present, preventing errors when optional files are missing.Improvements to bundle creation logic:
default_config.binarypbandparameter-descriptor-set.proto.binfrom the container if they exist, preventing failures when these files are absent.TAR_FILES), ensuring only existing files are added toimages/$SERVICE_NAME.bundle.tar.