Allow for duplicate meshes in ROS bridge #69
Merged
+20
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Yadunund
approved these changes
Dec 3, 2025
Contributor
Yadunund
left a comment
Yadunund
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of
flowstate_ros_bridge, we have a check that skips publishing markers if another marker with the sameglbmesh is found..This doesn't play well with cases where we do actually have multiple instances of the same mesh, where the first instance will be published but all the others will be silently skipped.
This PR changes the behavior to allow multiple copies of the same mesh, while making sure we cache gltf data so we don't do unnecessary work to fetch the same gltf multiple times for multiple instances of the same mesh.