fix: isPlainObject incorrectly identifies objects wrapped in a Proxy object in Safari 10#1379
Merged
Conversation
…object in Safari 10 (#1378)
kazupon
approved these changes
May 30, 2023
Member
kazupon
left a comment
There was a problem hiding this comment.
Sorry for my late reply!
Good contribution!
Thanks!
BobbieGoede
added a commit
to BobbieGoede/vue-i18n-next
that referenced
this pull request
Sep 15, 2024
kazupon
pushed a commit
that referenced
this pull request
Sep 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I noticed that in Safari 10, the
isPlainObjectmethod used invue-i18ncan lead to an issue where objects wrapped in aProxyobject, such as those returned by therefmethod in Vue, are incorrectly identified as non-plain objects. This can result in an emptymessagesobject and the inability to retrieve localized content.To address this issue, I propose changing the
isPlainObjectmethod used invue-i18nto use theObject.prototype.constructorproperty to check if an object is a plain object. This method is more reliable and performs well in all browsers, including Safari 10.Here's the updated code for the
isPlainObjectmethod:This change should resolve the issue in Safari 10 and ensure that objects wrapped in a
Proxyobject are correctly identified as plain objects.Please let me know if you have any questions or concerns. Thanks for considering this PR!
Best regards
closes(#1378)