feat: support vue 2.7 and vue-router 3.6 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Sep 18, 2022
| "peerDependencies": { | ||
| "@vue/composition-api": "^1.4.0", | ||
| "vue": "^2.6.14 || ^3.2.0", | ||
| "vue": "^2.6.14 || ^2.7.0 || ^3.2.0", |
Collaborator
There was a problem hiding this comment.
Does it make sense to have both ^2.6.14 and ^2.7.0? The former already takes care of the latter and what does the latter really mean in presence of the former? Does it restrict the whole range to ^2.7.0 or not?
Same for the vue_router change below.
Collaborator
There was a problem hiding this comment.
I can see in https://semver.npmjs.com/ that ^2.6.14 || ^2.7.0 matches from ^2.6.14 so that's good but then I don't see much point in adding ^2.7.0 anyway.
Member
Author
There was a problem hiding this comment.
Thank you for your comment.
The semver spec certainly doesn't make sense, but I don't know why, but it didn't work with peerDependencies, so I did 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Additional context