fix: resolveRoute losing query parameters for string routes
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbieGoede
force-pushed
the
fix/resolve-route-string-query-loss
branch
2 times, most recently
from
8c074f1 to
92bee7b
Compare
BobbieGoede
force-pushed
the
fix/resolve-route-string-query-loss
branch
from
92bee7b to
d77bfc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of treating
_routeof typestringas a{ path: _route }, the route is split by?and the query parameters are converted into an object to be used later in resolution.Linked Issues
Fixes #42
Downstream nuxt-modules/i18n#2020