Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI editors for BPL and DTL files #730

Closed
wants to merge 3 commits into from

Conversation

ty-d
Copy link
Contributor

@ty-d ty-d commented Aug 16, 2021

This PR fixes #60

Notes:

  • This feature is not ready to be merged into the extension.
  • The BPL/DTL editors will not work without changes to server side classes, which are being worked on outside of this PR
  • This requires VS Code version 1.59 because of webview bugs that caused SVGs to not load.

This adds a custom editor for .bpl and .dtl files. Whenever those files are opened, the GUI Zen editor will be opened allowing the user to edit and save the class, which automatically updates the class version. Edits to the class version will cause the Zen version to reload with the new changes when the user clicks on it, unless the Zen version has also been edited in which case it will ask the user whether to reload or not. The view other command can be used to switch between the .cls and .bpl/.dtl versions.

A class that has been exported to the local filesystem will be updated by the Zen editor in the same way, so client side source control should not be an issue.

Keyboard shortcuts implemented in the webview:

  • Ctrl + S = save the document
  • Ctrl + Z = undo
  • Ctrl + Shift + V = view other (open the class version)

Copy link
Contributor

@isc-bsaviano isc-bsaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ty-d Please update this line in package.json to reflect the new minimum version of 1.59 according to the PR description

"engines": {
"vscode": "^1.43.0"
},

@gjsjohnmurray
Copy link
Contributor

PMC decided unanimously to close this without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the support for BPL and DTL files
3 participants