[feat] Wire up create font project submit button to the backend and smart contract apis #11
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jsanchez034
requested review from
miglconts,
eduairet,
hyperalchemy and
bomanaps
and removed request for
miglconts and
eduairet
| } catch(err) { | ||
| console.log(err); | ||
| } | ||
| } |
There was a problem hiding this comment.
I'll take this as example for the user :) Does make sense to have these files:
createIPFontsUser.jseditIPFontsUser.jscreateLensUser.js(just in testnet)editLensUser.js
And condition them according to how the user has been authenticated
There was a problem hiding this comment.
Nice yeah makes sense 😃
| functionName: 'addressToUser', | ||
| args: [lensAddress] | ||
| }); | ||
| const { createdAt } = await getIPFontsUser(address); | ||
|
|
||
| const isRegistered = !ethers.BigNumber.from(createdAt).isZero; | ||
|
|
There was a problem hiding this comment.
This file is related to the part I'm testing, didn't modify it (but I used parts of it) to avoid merging stashing, but my plan is to refactor some of the logic I'm using in the form here, does that make sense?
There was a problem hiding this comment.
cool yeah makes sense to me 👍
|
|
||
| export default function Submit() { | ||
| const { activeStepIndex, setActiveStepIndex, formData, setFormData } = | ||
| useContext(FormContext); | ||
| const { address, isConnected } = useAccount(); |
There was a problem hiding this comment.
Haven't seen this before, looks smart!
| perCharacterMintPrice: formData.setPrice, | ||
| mintLimit: formData.minLimit | ||
| }); | ||
| } |
There was a problem hiding this comment.
This file really got cleaned 💯 sweet!
| return res.status(401).json({ message: 'You have to sign-in first' }); | ||
| } | ||
|
|
||
| return await storeFontMetadata(req, res); |
There was a problem hiding this comment.
What do you think about making a generic storeMetadata method instead storeFontMetadata and using it for both, lens and user, maybe add a string parameter that makes custom messages "Error uploading ${type} metadata"
There was a problem hiding this comment.
ah yeah good call 👍 Let me update in a follow up PR. The type variable could be a param passed in the request body
| }); | ||
|
|
||
| return result.cid.toString(); | ||
| } |
There was a problem hiding this comment.
Already used this file for the user :) thanks a lot JP
This change wires up the create font project submit button to the backend and smart contract apis so that the create font project wizard works end to end. The following changes where made as part of this work...
/api/upload-metadataendpoint for uploading smart contract entity metadata to IPFS using Infura IPFS nodecreateIPFontProjectclient api util function which takes care of making backend calls to upload font files and font project metadata json to IPFS along with making thecreateFontProjectin our smart contractAfter this change all metadata json uploads will be done through our Infura IPFS node and actual font files will be uploaded to IPFS using web3.storage. web3.storage does not pin our metadata files quick enough for our graph subgraph to pick up the files during indexing leading to null data in our subgraph queries. Thanks @hyperalchemy for the heads up on this 🙌 😃