Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created job for sending monthly invoices #2424

Merged
merged 10 commits into from
Aug 31, 2022
Merged

Created job for sending monthly invoices #2424

merged 10 commits into from
Aug 31, 2022

Conversation

maricavor
Copy link
Contributor

@maricavor maricavor marked this pull request as draft August 21, 2022 16:14
@viezly
Copy link

viezly bot commented Aug 21, 2022

This pull request is split into 7 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • app/jobs
  • app/mailers
  • app/models
  • app/views
  • config/locales
  • db
  • lib/core_monkey_patches
  • lib/gem_monkey_patches
  • test

@maricavor maricavor marked this pull request as ready for review August 22, 2022 08:17
Copy link
Contributor

@vohmar vohmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in staging set test_registrar setting to true for most of the registrars to avoid flood of montly invoices
  • run monthly invoice job in registry: bin/rails r -e staging SendMonthlyInvoicesJob.perform_now
  • big error, no invoices created: /home/registry/.rbenv/versions/3.0.3/lib/ruby/gems/3.0.0/bundler/gems/e_invoice-312cac173935/lib/e_invoice/generator.rb:172:in `format': can't convert nil into Float (TypeError)...

@maricavor maricavor requested a review from vohmar August 29, 2022 11:10
@vohmar vohmar merged commit dd34dce into master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monthly reports/invoices to registrars
2 participants