Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended csv domain export #2407

Merged

Conversation

OlegPhenomenon
Copy link
Contributor

Close #2359

@viezly
Copy link

viezly bot commented Jul 29, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@OlegPhenomenon
Copy link
Contributor Author

@vohmar
exporting a CSV file no longer depends on pagination, but regarding the implementation of an asynchronous job for this purpose, there are a number of problems, you can read it here: https://stackoverflow.com/a/27084533

I see two solutions so far:
the first is to send the file for download via websockets and redis when the async task stops compiling a large list of domains. Since we will soon stop serving this portal, it seems to me that this will be a waste of time, and I hope everyone in the team will agree with me.

The second option is more compromise. If the number of domains is more than a certain number and it will really take a lot of time to generate a csv file, then one of the solutions for such a case is to send a csv file by mail

third option - your option?

@vohmar vohmar merged commit 92d7572 into master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registrar: CSV and PDF download puts only partial domainlist in the file
3 participants