-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status notes to repp domain serializer #2346
Conversation
Changes preview: |
325067f
to
8be0205
Compare
Update repp doc after merging this PR https://github.com/internetee/repp-apidoc |
@@ -15,7 +15,7 @@ def to_json(obj = domain) | |||
updated_at: obj.updated_at, expire_time: obj.expire_time, outzone_at: obj.outzone_at, | |||
delete_date: obj.delete_date, force_delete_date: obj.force_delete_date, | |||
contacts: contacts, nameservers: nameservers, dnssec_keys: dnssec_keys, | |||
statuses: obj.statuses, registrar: registrar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove this one? I though status and status note is a different things. Notes should store some information like email addresses and status should store the store of current object?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed because status_notes
has the statuses as hash keys and notes as values. So we have both data
@vohmar liked showing this way. But I can change. @OlegPhenomenon @vohmar which way do you suggest and prefer to use in this case?
Discussed this with @maricavor and we agreed that your initial proposal was better. So the idea is to drop the current statuses element and replace it with new one with hash keys ie
this will require changes on the client side, but we do not know any registrars using repp for info requests. So its only about our own registrar portal implementation that we will update accordingly Also please update repp documentation: |
65c3278
to
8be0205
Compare
close #2331