Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status notes to repp domain serializer #2346

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

thiagoyoussef
Copy link
Member

@thiagoyoussef thiagoyoussef commented Apr 12, 2022

close #2331

@thiagoyoussef thiagoyoussef self-assigned this Apr 12, 2022
@viezly
Copy link

viezly bot commented Apr 12, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@thiagoyoussef
Copy link
Member Author

Update repp doc after merging this PR https://github.com/internetee/repp-apidoc

@@ -15,7 +15,7 @@ def to_json(obj = domain)
updated_at: obj.updated_at, expire_time: obj.expire_time, outzone_at: obj.outzone_at,
delete_date: obj.delete_date, force_delete_date: obj.force_delete_date,
contacts: contacts, nameservers: nameservers, dnssec_keys: dnssec_keys,
statuses: obj.statuses, registrar: registrar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this one? I though status and status note is a different things. Notes should store some information like email addresses and status should store the store of current object?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed because status_notes has the statuses as hash keys and notes as values. So we have both data
@vohmar liked showing this way. But I can change. @OlegPhenomenon @vohmar which way do you suggest and prefer to use in this case?

@vohmar
Copy link
Contributor

vohmar commented Apr 28, 2022

Discussed this with @maricavor and we agreed that your initial proposal was better. So the idea is to drop the current statuses element and replace it with new one with hash keys ie

"statuses": {
    "inactive": "",
    "serverForceDelete": "manually",
    "serverRenewProhibited": "",
    "serverTransferProhibited": ""
}

this will require changes on the client side, but we do not know any registrars using repp for info requests. So its only about our own registrar portal implementation that we will update accordingly

Also please update repp documentation:
https://internetee.github.io/repp-apidoc/#introduction

@vohmar vohmar merged commit 29614bc into master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPP: add status notes
4 participants