Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off token request in oneoff params #85

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

OlegPhenomenon
Copy link
Contributor

close #78

What's the problem?

  • The issue is that the callback endpoint receives a token parameter that is not expected. The callback mechanism operates in such a way that when it receives the expected parameter, it makes a request towards everypay. However, instead, it redirects to a non-existent page.

What did I do?

  • In the OneOff request documentation, there's a request_token parameter which, according to the documentation notes, says that the token should arrive in response after the payment to manage future user payments. Since we are not using the token approach, I disabled this function.

How to test/review?

  • Ensure that all payments still work, the correct data is added to the eis billing dashboard, auctions are paid, the registrar's balance is credited, credit is replenished in eeid, all tests pass. It's also important to monitor logs in production to ensure that there are no longer errors, as indicated in the issues attached to this PR.

@vohmar vohmar merged commit 6734147 into master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error in the logs
2 participants