Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bundle audit gem and added it to github CI #83

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

OlegPhenomenon
Copy link
Contributor

@OlegPhenomenon OlegPhenomenon commented Jul 20, 2023

Tasks

  • Adding new tasks to CI that check for vulnerabilities in dependencies and code quality
  • Fixes to critical pieces of code

What's fixed

  • fixed code responsible for LHV Connect connection
  • changed the method for serializing cookies from marshal to json
  • updated session_store values, added http:only which ensures that cookie operations cannot be executed via javascript

What's checked

  • bundle-audit and brakeman showed no problems
  • production.rb has: config.force_ssl = true
  • cookie time is set to 30 minutes
  • output data screening in erb templates
  • Rails.application.config.filter_parameters += [ :passw, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn] filter sensitive data. Can be added more parameters
    What else can be filtering?

What to test?
Test how the connection with LHV Connect works:

  • test on dev environment
  • test on staging environment
  • test on test environment

Test authorization and cookies, as well as session lifetime

  • Log in to the account and after 30 minutes check if the user is still logged in or if the session is no longer valid.

What else can be added?

  • Reset the session if user login with different browser agent or IP-address

@OlegPhenomenon OlegPhenomenon force-pushed the added-security-flow-to-ci branch 2 times, most recently from 6decada to 01d9d9b Compare July 20, 2023 09:03
@OlegPhenomenon OlegPhenomenon removed the request for review from vohmar July 21, 2023 12:27
@OlegPhenomenon OlegPhenomenon force-pushed the added-security-flow-to-ci branch 3 times, most recently from 3f11784 to f2efecc Compare October 31, 2023 14:47
@vohmar vohmar merged commit dd027b5 into master Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants