-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data imports #5588
Merged
Merged
Data imports #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
cdrini
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mek's en route with the changes. Code lgtm after these. We tested doing the import flow with BWB and looks like it's running smoothly!
Might want to do a test that IA is still running smoothly.
Merge at your discretion.
Co-authored-by: Drini Cami <[email protected]>
Co-authored-by: Drini Cami <[email protected]>
hornc
reviewed
Sep 3, 2021
hornc
reviewed
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
mekarpeles
commented
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #5583 which should be merged first which updates the schema for the
import_items
table.Closes first half of #5130
Allows manage-imports.py to add
{"data": {...}}
records in addition to{"ia_id": "..."}
records to the https://openlibrary.org/admin/imports pipeline.Testing
tty1
tty2
tty3
:tty4
Go back to
tty2
Stakeholders