Don't protect deprecated system subjects #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hornc
force-pushed
the
featue/2107-no-more-system-subject-protection
branch
from
c4634a0 to
d57a63a
Compare
cdrini
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
- ✅ No dangling refs to
SYSTEM_SUBJECTS - ✅ No dangling refs to
_prevent_system_subjects_deletion - ✅ Test before: adding all system subjects allowed for non-admin
- ✅ Test before: removing any system subjects dis-allowed for non-admin
- ✅ Test after: adding all system subjects allowed for non-admin
- ✅ Test after: removing any system subjects allowed for non-admin
(Note: I tested this locally by editing the is_admin fn to return false)
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with, but doesn't c.l.o.s.e #2107
These former 'system' subjects
["Accessible Book", "Lending Library", "In Library", "Protected DAISY"]are no longer used by the system to indicate lending status and have been deprecated as they are not technically subjects. See #2107This PR allows any user / librarian to clean these from records if they encounter them.
Deletes code => reduces complexity.
Technical
Testing
Evidence
Stakeholders