Add time delay for displaying error - #218
Merged
Merged
Conversation
iisa
approved these changes
Jun 28, 2019
iisa
left a comment
iisa
left a comment
Contributor
There was a problem hiding this comment.
Ok, we can start at 3 seconds. LGTM!
iisa
pushed a commit
that referenced
this pull request
Jul 10, 2019
Add player to state Rebase fix Rebase fix Rebase fix Add changes from code review Retrieve next trackNumber available for autoplay and loop to first track at end of playlist Prevent user and track interaction while player gets ready Add stylesheet Reload youtube player object after switching channels Hide ia-player when not in use Remove autoplay Add time delay for displaying error (#218) Remove comments and add jsdocs Tie up loose ends Clear timeout when new track selected Reference timer on component Stop autoplaying the youtube player after changing channels
iisa
pushed a commit
that referenced
this pull request
Jul 10, 2019
Add player to state Rebase fix Rebase fix Rebase fix Add changes from code review Retrieve next trackNumber available for autoplay and loop to first track at end of playlist Prevent user and track interaction while player gets ready Add stylesheet Reload youtube player object after switching channels Hide ia-player when not in use Remove autoplay Add time delay for displaying error (#218) Remove comments and add jsdocs Tie up loose ends Clear timeout when new track selected Reference timer on component Stop autoplaying the youtube player after changing channels
iisa
pushed a commit
that referenced
this pull request
Jul 10, 2019
Add player to state Rebase fix Rebase fix Rebase fix Add changes from code review Retrieve next trackNumber available for autoplay and loop to first track at end of playlist Prevent user and track interaction while player gets ready Add stylesheet Reload youtube player object after switching channels Hide ia-player when not in use Remove autoplay Add time delay for displaying error (#218) Remove comments and add jsdocs Tie up loose ends Clear timeout when new track selected Reference timer on component Stop autoplaying the youtube player after changing channels
iisa
pushed a commit
that referenced
this pull request
Jul 10, 2019
Add player to state Rebase fix Rebase fix Rebase fix Add changes from code review Retrieve next trackNumber available for autoplay and loop to first track at end of playlist Prevent user and track interaction while player gets ready Add stylesheet Reload youtube player object after switching channels Hide ia-player when not in use Remove autoplay Add time delay for displaying error (#218) Remove comments and add jsdocs Tie up loose ends Clear timeout when new track selected Reference timer on component Stop autoplaying the youtube player after changing channels
koderjoker
added a commit
that referenced
this pull request
Jul 10, 2019
- Add player to state - Rebase branch - Add feedback from code review - Retrieve next trackNumber available for autoplay - Loop to first track at end of playlist - Prevent user and track interaction while player gets ready - Add stylesheet - Reload youtube player object after switching channels - Hide ia-player when not in use - Remove autoplay - Add time delay for displaying error (#218) - Remove comments and add jsdocs - Clear timeout when new track selected - Reference timer on component - Stop autoplaying the youtube player after changing channels - Change url when track changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Subtask of #213
Technical
Uses setTimeout() to display the error for a longer time, before switching on to the next task.
Evidence
