Skip to content

Replace YouTube embed with YouTube API integration - #208

Merged
koderjoker merged 2 commits into
internetarchive:178-youtube-playerfrom
koderjoker:178-youtube-player
Jul 10, 2019
Merged

Replace YouTube embed with YouTube API integration#208
koderjoker merged 2 commits into
internetarchive:178-youtube-playerfrom
koderjoker:178-youtube-player

Conversation

@koderjoker

@koderjoker koderjoker commented Jun 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Closes #178

Task List

  • To replace basic embedded with Youtube iframe API
  • To play video of any track selected by a user
  • To autoplay next track when video finishes playing
  • To move on to the next track if player encounters an error
  • To avoid restarting video if the same track is selected
  • To ensure tracklist is rendered in all instances
  • To loop back to first track at the end of playlist
  • To prevent video loading till the player is ready
  • To ensure player is rendered again after switching through channels
  • To ensure player works on mobile devices
  • To remove comments
  • To add jsdocs
  • To make sure files are in the correct location
  • To delete redundant code
  • To ensure code passes linter check
  • To rebase to include latest changes

Evidence

Track selection
Youtube API integration

Autoplay
Autoplay

Error handling
Error handling

@koderjoker
koderjoker requested a review from iisa June 23, 2019 17:59
@iisa
iisa requested a review from shaneriley June 25, 2019 17:04
@iisa

iisa commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

@shaneriley, I tagged you as a reviewer for @koderjoker's code. She can benefit from your deep knowledge. Currently, it's WIP, but she has requested an initial review for it so she can iterate. Would you be able to check it out?

@shaneriley

shaneriley commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

Yeah, I can review it this evening.

shaneriley
shaneriley suggested changes Jun 26, 2019
View reviewed changes
Comment thread packages/ia-components/sandbox/audio-players/audio-player-main.jsx
Comment thread packages/ia-components/sandbox/audio-players/audio-player-main.jsx Outdated
Comment thread packages/ia-components/sandbox/audio-players/audio-player.stories.js Outdated
Comment thread packages/ia-components/sandbox/audio-players/youtube-player.jsx Outdated
Comment thread packages/ia-components/sandbox/audio-players/youtube-player.jsx Outdated
Comment thread packages/ia-components/sandbox/audio-players/youtube-player.jsx Outdated
Comment thread packages/ia-components/sandbox/audio-players/youtube-player.less
Comment thread packages/ia-components/sandbox/details/NavWrap.jsx Outdated
@koderjoker
koderjoker force-pushed the 178-youtube-player branch from 766dc6e to 57e5d97 Compare June 26, 2019 16:26
@iisa iisa changed the title WIP: Replace YouTube embed with YouTube API integration Replace YouTube embed with YouTube API integration Jun 28, 2019
@koderjoker
koderjoker force-pushed the 178-youtube-player branch from 08a48a2 to 9f26624 Compare July 10, 2019 20:15
@koderjoker
koderjoker changed the base branch from master to 178-youtube-player July 10, 2019 20:15
iisa
iisa approved these changes Jul 10, 2019
View reviewed changes

@iisa iisa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koderjoker
koderjoker merged commit 37659a7 into internetarchive:178-youtube-player Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iisa iisa iisa approved these changes
+1 more reviewer
@shaneriley shaneriley shaneriley requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koderjoker @iisa @shaneriley