Skip to content

[WIP] Flatten directory structure - #177

Merged
iisa merged 6 commits into
internetarchive:masterfrom
koderjoker:169-flatten-directory-structure
Jun 7, 2019
Merged

[WIP] Flatten directory structure#177
iisa merged 6 commits into
internetarchive:masterfrom
koderjoker:169-flatten-directory-structure

Conversation

@koderjoker

@koderjoker koderjoker commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Description

Closes #169

Task list

  • Adhere to style guide for all edits
  • Move folders in components to theatres
  • Shift data-for-stories to sandbox
  • Shift theatre-styling.less to config.js
  • Shift svgs to sandbox

Comment thread packages/ia-components/index.js Outdated
Comment thread packages/ia-components/index.less Outdated
Comment thread packages/ia-components/index.less Outdated

@iisa iisa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good! i had one more suggestion - let's raise up the components inside of /players-by-type to just be inside of /audio-players. So it becomes a sibling of audio-player-main.jsx

@koderjoker
koderjoker marked this pull request as ready for review June 7, 2019 06:36
@koderjoker
koderjoker requested a review from iisa June 7, 2019 07:06

@iisa iisa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Running well.

@iisa
iisa merged commit 739c035 into internetarchive:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flatten Directory Structure of ia-components sandbox

2 participants