Skip to content

Conversation

@oana-lolea
Copy link
Contributor

@oana-lolea oana-lolea commented Oct 15, 2025

Changes proposed in this pull request

  • Added senderWalletAddress to incoming-payment GraphQL table

Context

Fixes #3647 | RAF-1164

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 40.20
  • Iterations/s: 13.40
  • Failed Requests: 0.00% (0 of 2417)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 872 kB 15 kB/s
     data_sent......................: 1.9 MB 31 kB/s
     http_req_blocked...............: avg=8.6µs    min=1.78µs   med=5.3µs    max=1.92ms   p(90)=6.52µs   p(95)=7.39µs  
     http_req_connecting............: avg=503ns    min=0s       med=0s       max=490.81µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=98.85ms  min=6.58ms   med=80.69ms  max=598.35ms p(90)=170.52ms p(95)=191.3ms 
       { expected_response:true }...: avg=98.85ms  min=6.58ms   med=80.69ms  max=598.35ms p(90)=170.52ms p(95)=191.3ms 
     http_req_failed................: 0.00%  ✓ 0         ✗ 2417
     http_req_receiving.............: avg=88.2µs   min=27.04µs  med=79.26µs  max=3.96ms   p(90)=113.88µs p(95)=144.29µs
     http_req_sending...............: avg=36.09µs  min=10.48µs  med=27.83µs  max=1.68ms   p(90)=40.95µs  p(95)=55.71µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=98.73ms  min=6.44ms   med=80.58ms  max=598.28ms p(90)=170.41ms p(95)=191.23ms
     http_reqs......................: 2417   40.197426/s
     iteration_duration.............: avg=298.11ms min=188.52ms med=283.75ms max=1.08s    p(90)=352.37ms p(95)=384.73ms
     iterations.....................: 806    13.404686/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@oana-lolea oana-lolea marked this pull request as ready for review October 15, 2025 11:21
@oana-lolea oana-lolea requested a review from mkurapov October 15, 2025 11:21
idempotencyKey: String
"Whether or not the incoming payment is being created for a card payment."
isCardPayment: Boolean
"The wallet address of the sender."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The wallet address of the sender."
"The sender's wallet address URL. Applicable only to card payments."

"incomingAmount": null,
"walletAddressId": "{{walletAddressId}}"
"walletAddressId": "{{walletAddressId}}",
"senderWalletAddress": "{{senderWalletAddress}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we can remove it from the bruno requests, I would say this is less developer facing, but more tied to the POS service

Comment on lines 219 to 221
if (this.senderWalletAddress) {
data.senderWalletAddress = this.senderWalletAddress
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's leave it out of the webhook payload for now - to not confuse integrators that this is something to expect on any incoming payents

@oana-lolea oana-lolea requested a review from mkurapov October 16, 2025 14:23
@oana-lolea oana-lolea requested a review from mkurapov October 21, 2025 07:58
@oana-lolea oana-lolea merged commit 76229df into pos-card-services Oct 21, 2025
25 of 34 checks passed
@oana-lolea oana-lolea deleted the oana/raf-1164 branch October 21, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants