-
Couldn't load subscription status.
- Fork 101
feat: added sender wallet address to incoming payment #3705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
| idempotencyKey: String | ||
| "Whether or not the incoming payment is being created for a card payment." | ||
| isCardPayment: Boolean | ||
| "The wallet address of the sender." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "The wallet address of the sender." | |
| "The sender's wallet address URL. Applicable only to card payments." |
| "incomingAmount": null, | ||
| "walletAddressId": "{{walletAddressId}}" | ||
| "walletAddressId": "{{walletAddressId}}", | ||
| "senderWalletAddress": "{{senderWalletAddress}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we can remove it from the bruno requests, I would say this is less developer facing, but more tied to the POS service
| if (this.senderWalletAddress) { | ||
| data.senderWalletAddress = this.senderWalletAddress | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's leave it out of the webhook payload for now - to not confuse integrators that this is something to expect on any incoming payents
Changes proposed in this pull request
senderWalletAddressto incoming-payment GraphQL tableContext
Fixes #3647 | RAF-1164
Checklist
fixes #numberuser-docslabel (if necessary)