feat(localenv): expose subject during consent in mock-ase #3666

njlie · 2025-09-24T22:36:48Z

Changes proposed in this pull request

Adds text during the consent screen to properly reference a subject information request.

Context

Closes RAF-997.

Checklist

Related issues linked using fixes #number
Tests added/updated
Make sure that all checks pass
Bruno collection updated (if necessary)
Documentation issue created with user-docs label (if necessary)
OpenAPI specs updated (if necessary)

github-actions · 2025-09-24T22:42:06Z

🚀 Performance Test Results

Test Configuration:

VUs: 4
Duration: 1m0s

Test Metrics:

Requests/s: 39.22
Iterations/s: 13.08
Failed Requests: 0.00% (0 of 2363)

📜 Logs


> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 853 kB 14 kB/s
     data_sent......................: 1.8 MB 30 kB/s
     http_req_blocked...............: avg=7.41µs   min=2.38µs  med=5.47µs   max=917.54µs p(90)=6.66µs   p(95)=7.18µs  
     http_req_connecting............: avg=568ns    min=0s      med=0s       max=696.2µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=101.31ms min=8.3ms   med=81.52ms  max=908.59ms p(90)=172.76ms p(95)=192.37ms
       { expected_response:true }...: avg=101.31ms min=8.3ms   med=81.52ms  max=908.59ms p(90)=172.76ms p(95)=192.37ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2363
     http_req_receiving.............: avg=92.8µs   min=32.73µs med=77.63µs  max=3.15ms   p(90)=115.96µs p(95)=155.48µs
     http_req_sending...............: avg=37.93µs  min=10.08µs med=28.24µs  max=2.37ms   p(90)=42.06µs  p(95)=58.79µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=101.18ms min=8.19ms  med=81.44ms  max=908.5ms  p(90)=172.63ms p(95)=192.21ms
     http_reqs......................: 2363   39.221319/s
     iteration_duration.............: avg=305.42ms min=185.6ms med=289.51ms max=1.08s    p(90)=347.75ms p(95)=380.1ms 
     iterations.....................: 788    13.079306/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4

cozminu

LGTM

mkurapov · 2025-10-06T11:59:33Z

bruno/collections/Rafiki/Examples/Open Payments/Grant Request Outgoing Payment.bru

              }
          ]
      },
+      "subject": {


Let's have a separate example folder that just has two requests, this one (with just the subject request), and the grant continuation.

As a result, we should have the mock ASE be able to handle requests with just the subject field (without showing the 0 amount):

* feat(auth): add subject to grant * feat(auth): add subject to grant * fix(auth): grant access when is undefined * feat(auth): subject id validation * fix(auth): fix tests * Update packages/auth/src/graphql/schema.graphql Co-authored-by: Max Kurapov <[email protected]> * feat(auth): throw GrantError instead of Error * fix(auth): description for subIdFormat * fix(auth): trx in tests is knex * fix: grant service to throw only grant errors * fix(auth): address change requests * fix(auth): address change requests * fix tests * access token optional in grant response * fix(auth): move accessErrorsMap to grant * fix(auth): fix test for grant access * fix(auth): changed interaction generic error message * use main OpenAPI spec for Auth * fix(auth): approved grant does not return subject * fix(auth): remove unused import Co-authored-by: Max Kurapov <[email protected]> * fix(auth): make access_token optional in response * fix(deps): sha.js critical update * fix(deps): critical update * Update package.json Co-authored-by: Max Kurapov <[email protected]> * update pnpm lock file * change op specs version * feat(auth): update idp openapi spec * feat(auth): make idp standalone * chore(deps): update axios * fix(auth): access token in response when it shouldnt * fix(auth): tests * try to fix grype scan * try fix grype * restore 'fix' * try fix grype * try fix grype 2 * feat(localenv): expose subject during consent in mock-ase (#3666) * feat(localenv): expose subject during consent in mock-ase * feat: include client name in subject grant line * fix(mase): grantId not being retrieved * fix(mase): consent and confirmation texts * fix: handle subject-only grants properly --------- Co-authored-by: Cozmin Ungureanu <[email protected]> --------- Co-authored-by: Max Kurapov <[email protected]> Co-authored-by: Nathan Lie <[email protected]>

* feat(auth): add subject to grant * feat(auth): add subject to grant * fix(auth): grant access when is undefined * feat(auth): subject id validation * fix(auth): fix tests * Update packages/auth/src/graphql/schema.graphql Co-authored-by: Max Kurapov <[email protected]> * feat(auth): throw GrantError instead of Error * fix(auth): description for subIdFormat * fix(auth): trx in tests is knex * fix: grant service to throw only grant errors * fix(auth): address change requests * fix(auth): address change requests * fix tests * access token optional in grant response * fix(auth): move accessErrorsMap to grant * fix(auth): fix test for grant access * fix(auth): changed interaction generic error message * use main OpenAPI spec for Auth * fix(auth): approved grant does not return subject * fix(auth): remove unused import Co-authored-by: Max Kurapov <[email protected]> * fix(auth): make access_token optional in response * fix(deps): sha.js critical update * fix(deps): critical update * Update package.json Co-authored-by: Max Kurapov <[email protected]> * update pnpm lock file * change op specs version * feat(auth): update idp openapi spec * feat(auth): make idp standalone * chore(deps): update axios * fix(auth): access token in response when it shouldnt * fix(auth): tests * try to fix grype scan * try fix grype * restore 'fix' * try fix grype * try fix grype 2 * feat(localenv): expose subject during consent in mock-ase (#3666) * feat(localenv): expose subject during consent in mock-ase * feat: include client name in subject grant line * fix(mase): grantId not being retrieved * fix(mase): consent and confirmation texts * fix: handle subject-only grants properly --------- Co-authored-by: Cozmin Ungureanu <[email protected]> * fix(mase): handle subjectId null case * chore(mase): remove unused SubjectId type --------- Co-authored-by: Cozmin Ungureanu <[email protected]> Co-authored-by: Nathan Lie <[email protected]>

feat(localenv): expose subject during consent in mock-ase

3f7efa2

github-actions bot added the pkg: mock-ase label Sep 24, 2025

feat: include client name in subject grant line

8747fc7

njlie requested review from cozminu and mkurapov September 29, 2025 21:15

cozminu added 2 commits October 1, 2025 17:03

fix(mase): grantId not being retrieved

54c331d

fix(mase): consent and confirmation texts

5fdc691

cozminu marked this pull request as ready for review October 2, 2025 09:41

cozminu approved these changes Oct 2, 2025

View reviewed changes

mkurapov reviewed Oct 6, 2025

View reviewed changes

fix: handle subject-only grants properly

b7ab581

njlie requested a review from mkurapov October 9, 2025 19:42

mkurapov approved these changes Oct 14, 2025

View reviewed changes

njlie merged commit 55aa0a1 into cozmin/raf-996 Oct 14, 2025
32 of 38 checks passed

njlie deleted the nl/raf-997 branch October 14, 2025 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(localenv): expose subject during consent in mock-ase #3666

feat(localenv): expose subject during consent in mock-ase #3666

Uh oh!

njlie commented Sep 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

cozminu left a comment

Uh oh!

mkurapov Oct 6, 2025

Uh oh!

mkurapov Oct 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(localenv): expose subject during consent in mock-ase #3666

feat(localenv): expose subject during consent in mock-ase #3666

Uh oh!

Conversation

njlie commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request

Context

Checklist

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Performance Test Results

Uh oh!

cozminu left a comment

Choose a reason for hiding this comment

Uh oh!

mkurapov Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

mkurapov Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

njlie commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading