-
Couldn't load subscription status.
- Fork 101
fix(backend): fix webhook resolver filter for OP funded and cancelled events #3662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| const noFilter = | ||
| !filter || | ||
| (filter?.type?.in && | ||
| Array.isArray(filter.type.in) && | ||
| filter.type.in.length === 0) | ||
| const filterOrDefaults = noFilter | ||
| ? { type: { notIn: DEFAULT_EXCLUDED_TYPES } } | ||
| : filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think noFilter would be true if we pass in in: [] but notIn: ['something'] though, right? Meaning we would end up ignoring the notIn filter.
We can either
- Remove the
notInfilter from the schema (but still have it functional in the service method) - Do
const filter = { type: { notIn: DEFAULT_EXCLUDED_TYPES, in: <parse the in array> } }
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
Changes proposed in this pull request
outgoing_payment.fundedandoutgoing_payment.cancelledeventsContext
Checklist
fixes #numberuser-docslabel (if necessary)