Skip to content

feat(backend): Update handling of OutgoingPaymentCardDetails #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: feat: adding `card-service` and `point-of-sale`
merged 12 commits into from
Sep 23, 2025
Merged

feat(backend): Update handling of OutgoingPaymentCardDetails #3658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6a51fd9
feat(backend): update CardDetailsInput GraphQL type
mkurapov Sep 19, 2025
ccc939f
feat(backend): update OutgoingPaymentCardDetails model
mkurapov Sep 19, 2025
6a3e421
feat(backend): start publishing cardDetails in outgoing_payment.creat…
mkurapov Sep 19, 2025
bd47c19
chore(backend): remove old expiry check
mkurapov Sep 19, 2025
812b734
test(backend): update outgoing payment resolver test
mkurapov Sep 22, 2025
8d15c21
chore(backend): remove unused cardDetails from GraphQL API
mkurapov Sep 23, 2025
f8cf338
test(backend): update outgoing payment resolver test
mkurapov Sep 23, 2025
51c3c96
Merge branch 'pos-card-services' into max/raf-1169
mkurapov Sep 23, 2025
ff10284
chore(backend): update migration to not add already included requestId
mkurapov Sep 23, 2025
9abb1f7
chore(backend): update outgoing payment test
mkurapov Sep 23, 2025
c9c185e
feat(card-service): update outgoing payment creation with new payload
mkurapov Sep 23, 2025
38ba95d
test(backend): update outgoing payment test
mkurapov Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 5 additions & 34 deletions localenv/mock-account-servicing-entity/generated/graphql.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions packages/backend/migrations/20250919105030_update_outgoing_payment_card_details_data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
exports.up = function (knex) {
return knex.schema.alterTable('outgoingPaymentCardDetails', function (table) {
table.dropColumn('expiry')
table.dropColumn('signature')

table.jsonb('data').notNullable()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurapov is this the TLV data?
If it is, the ASE would need to extract the TLV data in order to retrieve the txn-counter and related TLV data.

Copy link
Contributor Author

@mkurapov mkurapov Sep 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koekiebox data is just JSON for flexibility, and in practice it is

{
    "signature": "", // generate AC response
    "payload": "", // generate AC payload
}

such that the cardholder's ASE can fetch it from the webhook and validate it.

See this Slack thread for example payload

table.timestamp('initiatedAt').notNullable()
})
}

/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
exports.down = function (knex) {
return knex.schema.alterTable('outgoingPaymentCardDetails', function (table) {
table.dropColumn('data')
table.dropColumn('initiatedAt')

table.string('signature').notNullable()
table.string('expiry').notNullable()
})
}
173 changes: 27 additions & 146 deletions packages/backend/src/graphql/generated/graphql.schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading