-
Notifications
You must be signed in to change notification settings - Fork 101
feat(card-service, pos-service): updating payment routes with new payload #3655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| WEBHOOK_SIGNATURE_SECRET: iyIgCprjb9uL8wFckR+pLEkJWMB7FJhgkvqhTQR/964= | ||
| WEBHOOK_SIGNATURE_VERSION: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating the docker compose file so that the webhooks between backend <> POS service are signed and correctly validated
| /* eslint-disable no-var */ | ||
| declare global { | ||
| interface BigInt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So BigInt is properly coerced before we pass it into the GraphQL requests
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes proposed in this pull request
After discussions in
#kernel-implementation, we have finalized the POS Service/paymentrequest that the POS will call.POST /paymentrequest body to be:{ "signature": "", // hex string (GEN AC result) "payload": "", // hex string (GEN AC payload) "amount": { "value:": "100", "assetScale": 2, "assetCode": "EUR"}, "senderWalletAddress": "https://example.com/alice", "receiverWalletAddress": "https://example.com/bob", "timestamp": 1758105181325 }POST /paymentrequest body was updated to:{ "requestId": "", "signature": "", "payload": "", "amount": { "value:": "100", "assetScale": 2, "assetCode": "EUR"}, "timestamp": 1758105181325 "senderWalletAddress": "https://example.com/alice", "incomingPaymentUrl": "https://example.com/incoming-payment/39393" }Context
Checklist
Fixes #3650 | RAF-1166
fixes #numberuser-docslabel (if necessary)