-
Notifications
You must be signed in to change notification settings - Fork 98
chore(deps): update dependency axios@>=0.8.1 <0.28.0 to v1 [security] #3642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate-npm-axios>=0.8.1-<0.28.0-vulnerability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs
|
c7462ed
to
920a9bd
Compare
920a9bd
to
1979fa5
Compare
1979fa5
to
9677173
Compare
9677173
to
c670d57
Compare
c670d57
to
cd36996
Compare
cd36996
to
5fc5377
Compare
beb16c4
to
5fc5377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Mend has cancelled the proposed renaming of the Renovate GitHub app being renamed to
mend[bot]
.This notice will be removed on 2025-10-07.
This PR contains the following updates:
>=0.28.0
->>=1.12.0
](https://renovatebot.com/diffs/npm/axios@>=0.8.1 <0.28.0/0.28.0/1.12.0)GitHub Vulnerability Alerts
CVE-2025-58754
Summary
When Axios runs on Node.js and is given a URL with the
data:
scheme, it does not perform HTTP. Instead, its Node http adapter decodes the entire payload into memory (Buffer
/Blob
) and returns a synthetic 200 response.This path ignores
maxContentLength
/maxBodyLength
(which only protect HTTP responses), so an attacker can supply a very largedata:
URI and cause the process to allocate unbounded memory and crash (DoS), even if the caller requestedresponseType: 'stream'
.Details
The Node adapter (
lib/adapters/http.js
) supports thedata:
scheme. Whenaxios
encounters a request whose URL starts withdata:
, it does not perform an HTTP request. Instead, it callsfromDataURI()
to decode the Base64 payload into a Buffer or Blob.Relevant code from
[httpAdapter](https://github.com/axios/axios/blob/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b/lib/adapters/http.js#L231)
:The decoder is in
[lib/helpers/fromDataURI.js](https://github.com/axios/axios/blob/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b/lib/helpers/fromDataURI.js#L27)
:config.maxContentLength
orconfig.maxBodyLength
, which only apply to HTTP streams.data:
URI of arbitrary size can cause the Node process to allocate the entire content into memory.In comparison, normal HTTP responses are monitored for size, the HTTP adapter accumulates the response into a buffer and will reject when
totalResponseBytes
exceeds[maxContentLength](https://github.com/axios/axios/blob/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b/lib/adapters/http.js#L550)
. No such check occurs fordata:
URIs.PoC
Run with limited heap to force a crash:
Since Node heap is capped at 100 MB, the process terminates with an out-of-memory error:
Mini Real App PoC:
A small link-preview service that uses axios streaming, keep-alive agents, timeouts, and a JSON body. It allows data: URLs which axios fully ignore
maxContentLength
,maxBodyLength
and decodes into memory on Node before streaming enabling DoS.Run this app and send 3 post requests:
Suggestions
Enforce size limits
For
protocol === 'data:'
, inspect the length of the Base64 payload before decoding. Ifconfig.maxContentLength
orconfig.maxBodyLength
is set, reject URIs whose payload exceeds the limit.Stream decoding
Instead of decoding the entire payload in one
Buffer.from
call, decode the Base64 string in chunks using a streaming Base64 decoder. This would allow the application to process the data incrementally and abort if it grows too large.Release Notes
axios/axios (axios@>=0.8.1 <0.28.0)
v1.12.0
Compare Source
Bug Fixes
Features
Contributors to this release
v1.11.0
Compare Source
Bug Fixes
Contributors to this release
v1.10.0
Compare Source
Bug Fixes
Features
Contributors to this release
v1.9.0
Compare Source
Bug Fixes
getSetCookie
by using 'get' method for caseless access; (#6874) (d4f7df4)Features
Contributors to this release
1.8.4 (2025-03-19)
Bug Fixes
allowAbsoluteUrls: false
withoutbaseURL
(#6833) (f10c2e0)Contributors to this release
1.8.3 (2025-03-10)
Bug Fixes
allowAbsoluteUrls
tobuildFullPath
inxhr
andfetch
adapters (#6814) (ec159e5)Contributors to this release
1.8.2 (2025-03-07)
Bug Fixes
Contributors to this release
1.8.1 (2025-02-26)
Bug Fixes
generateString
to platform utils to avoid importing crypto module into client builds; (#6789) (36a5a62)Contributors to this release
v1.8.4
Compare Source
Bug Fixes
allowAbsoluteUrls: false
withoutbaseURL
(#6833) (f10c2e0)Contributors to this release
v1.8.3
Compare Source
Bug Fixes
getSetCookie
by using 'get' method for caseless access; (#6874) (d4f7df4)Features
Contributors to this release
1.8.4 (2025-03-19)
Bug Fixes
allowAbsoluteUrls: false
withoutbaseURL
(#6833) (f10c2e0)Contributors to this release
1.8.3 (2025-03-10)
Bug Fixes
allowAbsoluteUrls
tobuildFullPath
inxhr
andfetch
adapters (#6814) (ec159e5)Contributors to this release
1.8.2 (2025-03-07)
Bug Fixes
Contributors to this release
1.8.1 (2025-02-26)
Bug Fixes
generateString
to platform utils to avoid importing crypto module into client builds; (#6789) (36a5a62)Contributors to this release
v1.8.2
Compare Source
Bug Fixes
Contributors to this release
v1.8.1
Compare Source
Bug Fixes
getSetCookie
by using 'get' method for caseless access; (#6874) (d4f7df4)Features
Contributors to this release
1.8.4 (2025-03-19)
Bug Fixes
allowAbsoluteUrls: false
withoutbaseURL
(#6833) (f10c2e0)Contributors to this release
1.8.3 (2025-03-10)
Bug Fixes
allowAbsoluteUrls
tobuildFullPath
inxhr
andfetch
adapters (#6814) (ec159e5)Contributors to this release
1.8.2 (2025-03-07)
Bug Fixes
Contributors to this release
1.8.1 (2025-02-26)
Bug Fixes
generateString
to platform utils to avoid importing crypto module into client builds; (#6789) (36a5a62)Contributors to this release
v1.8.0
Compare Source
Bug Fixes
Features
Reverts
BREAKING CHANGES
code relying on the above will now combine the URLs instead of prefer request URL
feat: add config option for allowing absolute URLs
fix: add default value for allowAbsoluteUrls in buildFullPath
fix: typo in flow control when setting allowAbsoluteUrls
Contributors to this release
1.7.9 (2024-12-04)
Reverts
Contributors to this release
1.7.8 (2024-11-25)
Bug Fixes
globalThis.TextEncoder
when available (#6634) (df956d1)Contributors to this release
1.7.7 (2024-08-31)
Bug Fixes
Contributors to this release
1.7.6 (2024-08-30)
Bug Fixes
Contributors to this release
1.7.5 (2024-08-23)
Bug Fixes
ReferenceError: navigator is not defined
for custom environments; (#6567) (fed1a4b)Contributors to this release
1.7.4 (2024-08-13)
Bug Fixes
Contributors to this release
1.7.3 (2024-08-01)
Bug Fixes
Contributors to this release
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.