Skip to content

feat(backend): add custom webhook URL for POS #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

feat(backend): add custom webhook URL for POS #3628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e04056c
feat(backend): add custom webhook URL for POS
sanducb Sep 4, 2025
8882d62
fix(backend): remove fallback webhook URL for POS
sanducb Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/backend/src/config/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,8 @@ export const Config = {
false
),
cardServiceUrl: optional(envString, 'CARD_SERVICE_URL'),
posServiceUrl: optional(envString, 'POS_SERVICE_URL')
posServiceUrl: optional(envString, 'POS_SERVICE_URL'),
posWebhookServiceUrl: optional(envString, 'POS_WEBHOOK_SERVICE_URL')
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/open_payments/payment/incoming/service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ describe('Incoming Payment Service', (): void => {
'Creates webhook event for POS service if card payment',
withConfigOverride(
() => config,
{ posServiceUrl: faker.internet.url() },
{ posWebhookServiceUrl: faker.internet.url() },
async (): Promise<void> => {
await expect(
IncomingPaymentEvent.query(knex).where({
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/webhook/service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ describe('Webhook Service', (): void => {
'adds webhooks for POS service if event was for a card payment',
withConfigOverride(
() => config,
{ posServiceUrl: faker.internet.url() },
{ posWebhookServiceUrl: faker.internet.url() },
async (): Promise<void> => {
const tenantId = crypto.randomUUID()
expect(
Expand Down
9 changes: 7 additions & 2 deletions packages/backend/src/webhook/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,11 @@ async function processNextWebhook(

if (webhook.metadata?.sendToPosService) {
await sendWebhook(deps, webhook, {
webhookUrl: `${deps.config.posServiceUrl}/webhook`
webhookUrl:
deps.config.posWebhookServiceUrl ??
(deps.config.posServiceUrl
? `${deps.config.posServiceUrl}/webhook`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, we can remove the fallback URL even. Might cause unexpected issues

: undefined)
})
} else {
const settings = await deps_.tenantSettingService.get({
Expand Down Expand Up @@ -316,7 +320,7 @@ export function finalizeWebhookRecipients(

if (
initiationReason === IncomingPaymentInitiationReason.Card &&
config.posServiceUrl
(config.posWebhookServiceUrl || config.posServiceUrl)
) {
recipients = recipients.concat([
{
Expand All @@ -328,6 +332,7 @@ export function finalizeWebhookRecipients(
])
} else if (
initiationReason === IncomingPaymentInitiationReason.Card &&
!config.posWebhookServiceUrl &&
!config.posServiceUrl
) {
logger?.warn('Could not create webhook recipient for point of sale service')
Expand Down
Loading