Skip to content

Conversation

@njlie
Copy link
Contributor

@njlie njlie commented Aug 25, 2025

Changes proposed in this pull request

  • Adds a call to create an outgoing payment during the POST /payment route in the card service.
  • Augments the input for createOutgoingPaymentFromIncomingPayment with cardDetails.

Context

Fixes RAF-1148.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Aug 25, 2025
@njlie njlie requested review from oana-lolea and sanducb August 25, 2025 17:37
@github-actions
Copy link

github-actions bot commented Aug 25, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 36.36
  • Iterations/s: 12.15
  • Failed Requests: 0.00% (0 of 2188)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 790 kB 13 kB/s
     data_sent......................: 1.7 MB 28 kB/s
     http_req_blocked...............: avg=7.31µs   min=1.91µs   med=5.73µs   max=679.96µs p(90)=7.61µs   p(95)=8.48µs  
     http_req_connecting............: avg=827ns    min=0s       med=0s       max=582.47µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=109.25ms min=8.57ms   med=86.74ms  max=899.47ms p(90)=195.11ms p(95)=216.04ms
       { expected_response:true }...: avg=109.25ms min=8.57ms   med=86.74ms  max=899.47ms p(90)=195.11ms p(95)=216.04ms
     http_req_failed................: 0.00%  ✓ 0        ✗ 2188
     http_req_receiving.............: avg=109.34µs min=29.65µs  med=94.23µs  max=2.96ms   p(90)=143.46µs p(95)=184.16µs
     http_req_sending...............: avg=42.32µs  min=11.54µs  med=32.05µs  max=2.93ms   p(90)=47.9µs   p(95)=62.94µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=109.1ms  min=8.34ms   med=86.61ms  max=899.35ms p(90)=195ms    p(95)=215.9ms 
     http_reqs......................: 2188   36.35977/s
     iteration_duration.............: avg=328.83ms min=196.41ms med=313.88ms max=1.23s    p(90)=389.87ms p(95)=419.59ms
     iterations.....................: 731    12.14762/s
     vus............................: 4      min=4      max=4 
     vus_max........................: 4      min=4      max=4 

Copy link
Contributor

@sanducb sanducb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@njlie njlie force-pushed the nl/raf-1148/call-outgoing-payment-creation branch from 0fc3822 to 4330126 Compare August 27, 2025 16:26
@njlie njlie merged commit 7d2cc15 into pos-card-services Aug 27, 2025
34 of 40 checks passed
@njlie njlie deleted the nl/raf-1148/call-outgoing-payment-creation branch August 27, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants