Skip to content

fix: (rafiki backend) Augment Wallet Address response with cardService field #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2025
Merged

fix: (rafiki backend) Augment Wallet Address response with cardService field #3552

merged 3 commits into from
Jul 10, 2025

Conversation

@MiguelLescasJorgeSebastian
Copy link

Changes proposed in this pull request

  • Added a new cardService field to wallet address discovery route responses.
  • Introduced the CARD_SERVICE_URL environment variable to configure the card service URL.

Context

fixes #3532

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Jul 10, 2025
@njlie
Copy link
Contributor

njlie commented Jul 10, 2025

Before this gets merged in, you'll need to run this command then fix any errors that appear and commit any formatted code:

pnpm format

After that this job will pass: https://github.com/interledger/rafiki/actions/runs/16193856864/job/45718324293?pr=3552

@njlie njlie merged commit d745131 into interledger:pos-card-services Jul 10, 2025
38 checks passed
njlie pushed a commit that referenced this pull request Aug 18, 2025
@MiguelLescasJorgeSebastian @HRadry @njlie
fix: (rafiki backend) Augment Wallet Address response with cardServic…
86a14f1 
…e field (#3552)

* feat: add cardServiceUrl configuration and update related routes

* feat: rename CARD_SERVICE_HOST to CARD_SERVICE_URL for consistency

* fix format

---------

Co-authored-by: HRadry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njlie njlie njlie approved these changes

Assignees

No one assigned

Labels

pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MiguelLescasJorgeSebastian @njlie @HRadry