Skip to content

Conversation

@RaulBR
Copy link

@RaulBR RaulBR commented Jul 10, 2025

Changes proposed in this pull request

Update Outgoing Payment GraphQl request to take in the expiry and the signature of a card to be passed along to the webhook

Context

In the POS - Card Service relationship the Card Service need to pass along the outgoing payment request toughener with the card details to the ASE
raf-1095

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Jul 10, 2025
@RaulBR RaulBR changed the title Raul/raf 1095 augment outgoing payments for card feat(bakcend): Raul/raf 1095 augment outgoing payments for card Jul 10, 2025
@github-actions
Copy link

github-actions bot commented Jul 10, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 44.47
  • Iterations/s: 14.83
  • Failed Requests: 0.00% (0 of 2675)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 965 kB 16 kB/s
     data_sent......................: 2.1 MB 34 kB/s
     http_req_blocked...............: avg=6.24µs   min=1.67µs   med=4.88µs   max=995.47µs p(90)=5.86µs   p(95)=6.34µs  
     http_req_connecting............: avg=262ns    min=0s       med=0s       max=184.97µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=89.35ms  min=6.52ms   med=76.03ms  max=626.12ms p(90)=148.13ms p(95)=165.46ms
       { expected_response:true }...: avg=89.35ms  min=6.52ms   med=76.03ms  max=626.12ms p(90)=148.13ms p(95)=165.46ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2675
     http_req_receiving.............: avg=81.06µs  min=17.88µs  med=71.68µs  max=1.76ms   p(90)=106.62µs p(95)=135.08µs
     http_req_sending...............: avg=36.63µs  min=8.63µs   med=26.48µs  max=2.44ms   p(90)=37.95µs  p(95)=50.9µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=89.24ms  min=6.36ms   med=75.7ms   max=625.97ms p(90)=148.03ms p(95)=165.36ms
     http_reqs......................: 2675   44.469523/s
     iteration_duration.............: avg=269.53ms min=185.95ms med=258.06ms max=1.01s    p(90)=313.04ms p(95)=355.72ms
     iterations.....................: 892    14.828716/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@njlie njlie changed the title feat(bakcend): Raul/raf 1095 augment outgoing payments for card feat(backend): Raul/raf 1095 augment outgoing payments for card Jul 10, 2025
@njlie njlie merged commit cb216fb into pos-card-services Aug 4, 2025
40 checks passed
@njlie njlie deleted the raul/raf-1095-augment-outgoing-payments-for-card branch August 4, 2025 18:28
njlie pushed a commit that referenced this pull request Aug 18, 2025
* feat(backend): add card information to outgoing payment graph ql

* fix(backend): save expiry as string MM/YY

* feature(backend): add mm/yy validation

* fix(backend): run prittier

* fix(backend): comments and set type to table name and relation

* fix(backend): remove unused deps

* feat(backend): add tests for outgoing payments with card details

* fix(backend): fix pr comments

---------

Co-authored-by: Raul Ranete <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants