-
Notifications
You must be signed in to change notification settings - Fork 101
feat(backend): Raul/raf 1095 augment outgoing payments for card #3539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
njlie
merged 8 commits into
pos-card-services
from
raul/raf-1095-augment-outgoing-payments-for-card
Aug 4, 2025
Merged
feat(backend): Raul/raf 1095 augment outgoing payments for card #3539
njlie
merged 8 commits into
pos-card-services
from
raul/raf-1095-augment-outgoing-payments-for-card
Aug 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
njlie
reviewed
Jul 10, 2025
packages/backend/src/open_payments/payment/outgoing/card/model.ts
Outdated
Show resolved
Hide resolved
njlie
reviewed
Jul 10, 2025
njlie
reviewed
Jul 10, 2025
packages/backend/src/open_payments/payment/outgoing/card/model.ts
Outdated
Show resolved
Hide resolved
njlie
approved these changes
Jul 30, 2025
njlie
approved these changes
Jul 30, 2025
njlie
pushed a commit
that referenced
this pull request
Aug 18, 2025
* feat(backend): add card information to outgoing payment graph ql * fix(backend): save expiry as string MM/YY * feature(backend): add mm/yy validation * fix(backend): run prittier * fix(backend): comments and set type to table name and relation * fix(backend): remove unused deps * feat(backend): add tests for outgoing payments with card details * fix(backend): fix pr comments --------- Co-authored-by: Raul Ranete <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg: backend
Changes in the backend package.
pkg: frontend
Changes in the frontend package.
pkg: mock-account-service-lib
pkg: mock-ase
type: source
Changes business logic
type: tests
Testing related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Update Outgoing Payment GraphQl request to take in the expiry and the signature of a card to be passed along to the webhook
Context
In the POS - Card Service relationship the Card Service need to pass along the outgoing payment request toughener with the card details to the ASE
raf-1095
Checklist
fixes #numberuser-docslabel (if necessary)