-
Couldn't load subscription status.
- Fork 101
feat: added card service client to initiate a payment from pos service #3535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
|
Haven't looked at everything yet, but you may want to either cherry-pick the jest test environment setup from #3528 or wait for it to be merged into the feature branch and then merge it into this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor nitpick but that's all
packages/point-of-sale/src/app.ts
Outdated
| posDeviceRoutes: Promise<PosDeviceRoutes> | ||
| posDeviceService: Promise<PosDeviceService> | ||
| merchantService: Promise<MerchantService> | ||
| cardServiceClient: Promise<CardServiceClient> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't think we need to add this to the AppServices interface if it's not going to be mounted to any routes
#3535) * Added card service client to initiate a payment
Changes proposed in this pull request
POS serviceto connect tocard serviceso that we can initiate a payment.Context
Fixes #3498
Checklist
fixes #numberuser-docslabel (if necessary)