Skip to content

Conversation

@oana-lolea
Copy link
Contributor

Changes proposed in this pull request

  • Created a client for POS service to connect to card service so that we can initiate a payment.

Context

Fixes #3498

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added the type: tests Testing related label Jul 9, 2025
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 40.59
  • Iterations/s: 13.55
  • Failed Requests: 0.00% (0 of 2442)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 882 kB 15 kB/s
     data_sent......................: 1.9 MB 31 kB/s
     http_req_blocked...............: avg=7.04µs   min=1.85µs   med=5.24µs   max=1.89ms   p(90)=6.25µs   p(95)=6.85µs  
     http_req_connecting............: avg=292ns    min=0s       med=0s       max=189.34µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=97.86ms  min=7.65ms   med=82.22ms  max=677.64ms p(90)=165.49ms p(95)=186.77ms
       { expected_response:true }...: avg=97.86ms  min=7.65ms   med=82.22ms  max=677.64ms p(90)=165.49ms p(95)=186.77ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2442
     http_req_receiving.............: avg=91.68µs  min=27.47µs  med=78.73µs  max=1.71ms   p(90)=115.33µs p(95)=146.63µs
     http_req_sending...............: avg=38.29µs  min=9.9µs    med=27.78µs  max=2.16ms   p(90)=40.78µs  p(95)=53.1µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=97.73ms  min=7.4ms    med=82.1ms   max=677.54ms p(90)=165.35ms p(95)=186.65ms
     http_reqs......................: 2442   40.590527/s
     iteration_duration.............: avg=294.86ms min=188.43ms med=283.16ms max=1.09s    p(90)=342.36ms p(95)=380.89ms
     iterations.....................: 815    13.546797/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@oana-lolea oana-lolea marked this pull request as ready for review July 9, 2025 11:42
@oana-lolea oana-lolea requested a review from njlie July 9, 2025 11:42
@njlie
Copy link
Contributor

njlie commented Jul 9, 2025

Haven't looked at everything yet, but you may want to either cherry-pick the jest test environment setup from #3528 or wait for it to be merged into the feature branch and then merge it into this one.

Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nitpick but that's all

posDeviceRoutes: Promise<PosDeviceRoutes>
posDeviceService: Promise<PosDeviceService>
merchantService: Promise<MerchantService>
cardServiceClient: Promise<CardServiceClient>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think we need to add this to the AppServices interface if it's not going to be mounted to any routes

@oana-lolea oana-lolea requested a review from njlie August 1, 2025 07:37
@oana-lolea oana-lolea merged commit fc3bf17 into pos-card-services Aug 4, 2025
94 of 114 checks passed
@oana-lolea oana-lolea deleted the oana/raf-1098 branch August 4, 2025 05:14
njlie pushed a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants