Skip to content

Conversation

@beniaminmunteanu
Copy link
Member

Changes proposed in this pull request

  • This PR adds the following missing dependencies in the package.json file:
-    "@koa/router": "^12.0.2",
-     "koa-bodyparser": "^4.4.1",
-     "pg": "^8.11.3",

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@beniaminmunteanu beniaminmunteanu requested a review from njlie July 8, 2025 14:50
@beniaminmunteanu beniaminmunteanu self-assigned this Jul 8, 2025
Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the lockfile issues in the GH actions

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 40.09
  • Iterations/s: 13.39
  • Failed Requests: 0.00% (0 of 2413)
📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 871 kB 15 kB/s
     data_sent......................: 1.9 MB 31 kB/s
     http_req_blocked...............: avg=8.23µs   min=1.9µs    med=5.59µs   max=4.19ms   p(90)=6.68µs   p(95)=7.21µs  
     http_req_connecting............: avg=297ns    min=0s       med=0s       max=261.48µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=99.15ms  min=6.27ms   med=83.5ms   max=646.63ms p(90)=167.15ms p(95)=186.36ms
       { expected_response:true }...: avg=99.15ms  min=6.27ms   med=83.5ms   max=646.63ms p(90)=167.15ms p(95)=186.36ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2413
     http_req_receiving.............: avg=96.51µs  min=26.71µs  med=81.36µs  max=3.29ms   p(90)=121.16µs p(95)=155.04µs
     http_req_sending...............: avg=37.24µs  min=9.31µs   med=28.89µs  max=2.72ms   p(90)=40.02µs  p(95)=52.26µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=99.01ms  min=6.11ms   med=83.41ms  max=646.55ms p(90)=166.94ms p(95)=186.25ms
     http_reqs......................: 2413   40.086447/s
     iteration_duration.............: avg=298.48ms min=207.56ms med=286.52ms max=1.22s    p(90)=350.06ms p(95)=391.29ms
     iterations.....................: 806    13.389837/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@beniaminmunteanu beniaminmunteanu merged commit 3786e36 into pos-card-services Jul 9, 2025
38 checks passed
@beniaminmunteanu beniaminmunteanu deleted the fix/cards-service-deps branch July 9, 2025 07:12
njlie pushed a commit that referenced this pull request Aug 18, 2025
* fix(cards-service): add dependencies to package.json

* chore(cards-service): lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants