Prune dependencies #400
Merged
Prune dependencies #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't reproduce the test failure locally, does that look spurious to you? |
emschwartz
requested changes
Oct 9, 2019
| @@ -13,7 +13,8 @@ use tokio::runtime::Builder as RuntimeBuilder; | |||
| mod redis_helpers; | |||
| use redis_helpers::*; | |||
|
|
|||
| #[test] | |||
| // TODO: reenable this test once it's no longer flaky | |||
There was a problem hiding this comment.
What's the problem you've been having with this? It works fine for me
There was a problem hiding this comment.
Amusingly it was failing for me 100% of the time yesterday, but now it works just fine.
added 6 commits
October 10, 2019 16:15
chore: update interledger-packet dependencies chore: update interledger-service dependencies chore: update dependencies for ildcp, http, router chore: update dependencies for btp, ccp, settlement, stream chore: update dependencies for spsp, service-util fix: remove vestigial file that was failing tests fix: comment out spurious tests chore: update dependencies for ilp-cli, interledger-store-redis chore: update dependencies for interledger-api chore: update dependencies for interledger, ilp-node
emschwartz
approved these changes
Oct 10, 2019
| @@ -13,7 +13,8 @@ use tokio::runtime::Builder as RuntimeBuilder; | |||
| mod redis_helpers; | |||
| use redis_helpers::*; | |||
|
|
|||
| #[test] | |||
| // TODO: reenable this test once it's no longer flaky | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits fixes #387 and addresses the lowest-hanging of #140. In practical terms this causes
cargo buildto now build 291 packages, down from 329 (down to 358 from 410 forcargo test), saving ten seconds overall for clean builds and shaving 3MB off of theilp-nodebinary.