Conversation
sander2
force-pushed
the
feat/tx-pause
branch
from
35ca4f6 to
e7eeff7
Compare
sander2
force-pushed
the
feat/tx-pause
branch
from
3584094 to
75fb238
Compare
gregdhill
reviewed
Jan 20, 2023
Member
gregdhill
left a comment
gregdhill
left a comment
There was a problem hiding this comment.
One comment on the change to the filter, otherwise LGTM!
sander2
force-pushed
the
feat/tx-pause
branch
from
aaab8fc to
80cf335
Compare
gregdhill
approved these changes
Jan 20, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking because of new events and removal of StatusCode::Shutdown
This adds a fork of substrate's WIP tx-pause pallet. I added some integration tests to ensure functionality, including one that shows that it shouldn't be possible to brick to parachain, i.e. democracy can always be used to recover.
I also removed StatusCode::Shutdown from security and its related tests, since with this pr it becomes redundant