Transition to url without root #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a transition is done with an URL, you should not include the root. Otherwise you end up with
`Uncaught Error: Assertion Failed: The URL '{root}/{url}' did not match any routes in your application`
error.
|
@jevanlingen thanks for this. Do you think you could add a test? |
|
To be honest, I don't know how I could change the |
|
Note: this bug is actually a regression of version 1.15.0. Before using the router service, the handle function updated the URL without the route: router.handleURL(urlWithoutRoot);
routerMicrolib.updateURL(urlWithoutRoot);(See changed files for pull #90) |
GavinJoyce
approved these changes
Nov 6, 2017
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ember-href-totranslates a route name correctly to an url, even if the app has a rootURL configured in the enviroment.js.But if a transition is done with an URL, you should not include the root. Otherwise you end up with a
error.