Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Github actions for CI #139

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Use Github actions for CI #139

merged 1 commit into from
Dec 9, 2020

Conversation

GavinJoyce
Copy link
Contributor

No description provided.

@GavinJoyce GavinJoyce changed the title github actions CI Use Github actions for CI Dec 9, 2020
@GavinJoyce GavinJoyce marked this pull request as ready for review December 9, 2020 15:28
patocallaghan
patocallaghan approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@patocallaghan patocallaghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The future is here!!! Does yarn test also cover linting or should we add that separately?

@GavinJoyce
Copy link
Contributor Author

GavinJoyce commented Dec 9, 2020 •
edited
Loading

It appears to, yes:

Screenshot 2020-12-09 at 15 30 51

Screenshot 2020-12-09 at 15 32 55

@GavinJoyce GavinJoyce merged commit 2315076 into master Dec 9, 2020
@GavinJoyce GavinJoyce deleted the gj/github-actions-ci branch December 9, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patocallaghan patocallaghan patocallaghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GavinJoyce @patocallaghan