Merge pull request #137 from intercom/gj/conditional-on

don't subscribe to `routeDidChange` if the router service is a mock
intercom · Sep 29, 2020 · b1c544f · b1c544f
2 parents 363cd30 + dc53100
commit b1c544f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/addon/helpers/href-to.js b/addon/helpers/href-to.js
@@ -30,7 +30,10 @@ export default class HrefToHelper extends Helper {
 
   init() {
     super.init();
-    this.router.on('routeDidChange', this.recompute.bind(this));
+
+    if (this.router && this.router.on) { // skip if the router service is mocked
+      this.router.on("routeDidChange", this.recompute.bind(this));
+    }
   }
 
   compute(params, namedArgs) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ember-href-to",
-  "version": "4.0.0",
+  "version": "4.1.0",
   "description": "A lightweight alternative to `{{link-to}}`",
   "scripts": {
     "lint:hbs": "ember-template-lint .",