Skip to content

Conversation

@Catalyst4222
Copy link
Contributor

About

This pull request merges the wait-for ext into the main library
The ext will be depreciated once the pr is merged

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

Copy link
Contributor

@mAxYoLo01 mAxYoLo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To take into account PR #1112 and avoid future conflicts

Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it shorter a bit?

@Catalyst4222
Copy link
Contributor Author

@EdVraz Due to the inconsistency of the length of the return values, along with the difficulty of conveying that to the user, I've changed wait_for_modal to return a tuple of the context with a list of the field values

@EepyElvyra EepyElvyra merged commit 160332a into interactions-py:unstable Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants