-
Notifications
You must be signed in to change notification settings - Fork 185
feat: merge wait-for into the main library #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mAxYoLo01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To take into account PR #1112 and avoid future conflicts
Co-authored-by: Max <[email protected]>
Co-authored-by: Max <[email protected]>
Co-authored-by: Max <[email protected]>
Co-authored-by: Max <[email protected]>
EepyElvyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make it shorter a bit?
|
@EdVraz Due to the inconsistency of the length of the return values, along with the difficulty of conveying that to the user, I've changed |
About
This pull request merges the wait-for ext into the main library
The ext will be depreciated once the pr is merged
Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.I've made this pull request: (check all that apply)
This is: