-
Notifications
You must be signed in to change notification settings - Fork 185
docs: Huge Docs revamp #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Huge Docs revamp #1112
Conversation
EepyElvyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target branch. Also why the removal of error docs?
I feel like since this is such a massive update, it belongs in unstable. Not only docs have been changed. Also, the docs branch is quite behind. The error page had nothing important in it, kind of like the cache one, nothing that a random person needs to see. |
Alright, that is fair and yeah I didn't see the code changes tbf |
|
I'm going to have to regenerate all the locale docs too with all the modifications, should I do it here or another PR? |
EepyElvyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has http been removed from index and searching?
Yes, as these methods should not be used by developers except if they have very good reasons to, which in this case I would guess they would check the source code at this point. |
Yeah I'm pro removing, sick of seeing "why is |
EepyElvyra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine and I don't want to make you a hell conflict when I make another refactor, or the other way around


About
This PR's goal is to massively revamp the docs to a more readable version.
In this PR is included:
?from docstrings:param:and:type:into a single line in docstringsChecklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.I've made this pull request: (check all that apply)
This is: